Vladimir Kotal

Results 485 comments of Vladimir Kotal

I tried reproducing the problem as follows: ``` cd /var/opengrok/src mkdir gittest mkdir RCS date > foo.txt git init git add foo.txt git commit -m foo foo.txt ``` followed by...

I am confused - how the directory `/srv/opengrok-src/git` could be git repository when it's missing the `.git` subdirectory ?

Okay, I see now. Making RCS detection smarter will solve the problem.

I see, this is being ignored because of the special directory listing in `IgnoredDirs`. Will reopen this however I can't help to think that using `RCS` as directory name is...

Well, git/svn at least use dotted dirs. To adress this, ignoredDirs wiuld need to see if the dir is a repo metadata dir.

Possibly `Repository` objects could register their `isRepositoryFor()` methods with `ignoredDirs`.

> but why the javadoc fails is a mystery for me > also mac build wasn't able to download some cve > @vladak any clues about above? the CVE download...

As for the Javadoc errors, I can see these in the log: ``` /home/runner/work/opengrok/opengrok/opengrok-indexer/src/main/java/org/opengrok/indexer/search/context/OGKUnifiedHighlighter.java:72: error: @param name not found Error: * @param indexSearcher a required instance Error: ^ Error: /home/runner/work/opengrok/opengrok/opengrok-indexer/src/main/java/org/opengrok/indexer/search/context/OGKUnifiedHighlighter.java:73:...

Even 100MB is not enough in some cases, e.g. 48 MB XHTML file can cause indexer to run out of heap (issue #907).