react-numeric-input icon indicating copy to clipboard operation
react-numeric-input copied to clipboard

Published 20 hours ago • verified publisher icon vlad-ignatov

'Format' function does not accept a number

Open heatherbooker opened this issue 7 years ago • 0 comments

The readme seems to indicate that the 'format' prop accepts a number, but in reality, it gets passed a string:

https://github.com/vlad-ignatov/react-numeric-input/blob/a981383f823594e6d9570bb7b5faf58a2dc2427f/src/NumericInput.jsx#L647

I can submit a PR but which would you prefer to see: changes to docs to clarify that it accepts a string, or changes to code to pass it the number without converting to string?

heatherbooker avatar Nov 01 '17 17:11 heatherbooker