vite icon indicating copy to clipboard operation
vite copied to clipboard

feat: add Angular example

Open gioboa opened this issue 1 year ago • 1 comments

I remember the integration with React, although the official default was CRA I was very happy to use Vite for its simplicity and speed. Angular has its official CLI, but thanks to @analogjs/vite-plugin-angular you can exploit the potential of Vite with Angular. Hope that helps.

angular

gioboa avatar Oct 11 '24 08:10 gioboa

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Thanks for the PR @gioboa! We discussed with @brandonroberts and others in the Vite team about it, and we think that having a starter for Angular may be a bit confusing. Brandon would recommend users to start from an Analog starter, and the Angular team would prefer folks to use their own Angular starter. It is still a good idea to have Angular in create-vite. What do you think if we remove the template, and instead we add an Angular option to create-vite that will have two custom commands (one to create an Angular app, another one to create an Analog app). Like we do for Vue/Nuxt, but in this case there will only be external create options and no template. See https://github.com/vitejs/vite/pull/18330

What do you think?

image

patak-dev avatar Oct 18 '24 13:10 patak-dev

Thanks for the exhaustive explanation. This sounds great to me too. That's a good option

gioboa avatar Oct 18 '24 14:10 gioboa

Let us know if you'd like to try to PR that feature @gioboa. Or we'll take it over.

patak-dev avatar Oct 18 '24 14:10 patak-dev

I'll do the PR for that. 😉

gioboa avatar Oct 18 '24 14:10 gioboa

See https://github.com/vitejs/vite/pull/18330

@patak-dev this is my PR, can you point me to the right one please?

gioboa avatar Oct 18 '24 15:10 gioboa

Oh, sorry about the wrong link. This is how we do the jump to create-nuxt in the Vue option https://github.com/vitejs/vite/blob/bae6a37628c4870f3db92351e8af2a7b4a07e248/packages/create-vite/src/index.ts#L109

patak-dev avatar Oct 18 '24 15:10 patak-dev