vite icon indicating copy to clipboard operation
vite copied to clipboard

feat: add `environment::listen`

Open sapphi-red opened this issue 1 year ago • 1 comments

Description

The upside of this approach is that this makes the implementation of environments cleaner IMO.

sapphi-red avatar Oct 03 '24 03:10 sapphi-red

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

I tried this API here: https://github.com/sapphi-red/daienjo-architecture/blob/966c60a5a94dcc388ba163ddbe9f2ba3435b2cbb/environment-pkgs/workerd/index.ts#L89-L290

I had to pass in hot always even if it might be false later. I'm making hot noop when it should be hot: false. (previous code)

Other than that, the API worked fine.

sapphi-red avatar Oct 17 '24 02:10 sapphi-red

Thanks for exploring the different options for the API @sapphi-red!

patak-dev avatar Oct 17 '24 11:10 patak-dev