vite icon indicating copy to clipboard operation
vite copied to clipboard

fix(legacy): emit css assets when cssCodeSplit and modernChuns is off

Open armano2 opened this issue 1 year ago • 2 comments

Description

This change allows assets to be emitted when renderModernChunks is set to false i noticed this issue when i tried using cssCodeSplit: false with renderModernChunks: false

Additional context

Partially fixes issue #2062


What is the purpose of this pull request?

  • [x] Bug fix
  • [ ] New Feature
  • [ ] Documentation update
  • [ ] Other

Before submitting the PR, please make sure you do the following

  • [x] Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • [x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • [x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • [x] Update the corresponding documentation if needed.
  • [x] Ideally, include relevant tests that fail without this PR but pass with it.

armano2 avatar Mar 08 '24 20:03 armano2

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-dev is there anything else that i have to do here?

armano2 avatar Jul 30 '24 22:07 armano2