Vishes
Vishes
@nejch as far as I know it's really bad practice to implement every methods' sync functions through ``` loop = asyncio.get_event_loop() loop.run_until_complete(async_foo()) ``` So without sync methods that would break...
@nejch yeah, as i was saying it's not that simple to being able to create async/sync library (thats why we have ton of sync and async library separate), as it...
@bufferoverflow @max-wittig i've seen that you liked the comment that is about maintaining only one library (the current one) and having async/sync interface. That's a so much different that i've...
@bufferoverflow i believe it crutial to have async library if you want to build an application based on async features, more and more applications begin to be developed with async...
@max-wittig - https://github.com/brettcannon/gidgethub - https://github.com/terrycain/aioboto3 - https://github.com/Fahreeve/aiovk/tree/master/aiovk - https://github.com/csko/gdax-python-api - https://github.com/TwitchIO/TwitchIO - https://github.com/odrling/peony-twitter I can search for more. More of the api wrapper libraries are still sync just because of...
@max-wittig i've realized how much work it will require to maintain two libraries. I totally ok with supporting the async one, but to have two up-to-date versions of mostly same...
@nejch @max-wittig @bufferoverflow @khvn26 i've succeeded in combining async and sync interfaces: #1036 I've tried to make as less changes as possible and don't brake initial design solution. My next...
@nejch that was some sort of challenge that bugged me, that's why it was quick. About inspiration, i only got it from `httpx`, the _client_ implementation: [`_client.py`](https://github.com/encode/httpx/blob/master/httpx/_client.py), with base class...
@nejch i have a question about functional tests, do you have ideas how to omit copy and paste? Because we want to test async and sync interface, thats for sure,...
List of notable changes: https://github.com/python-gitlab/python-gitlab/pull/1036#issuecomment-595308609