Soft deleting a vertex does not remove properties

[joeferner]

1. Create a vertex with a property
2. Soft delete that vertex
3. Create a new vertex with the same id

Expected Properties should be empty.

Found Properties contain the properties from before the soft delete

[mwizeman]

@joeferner When soft deleting the property rows during step 2 of your description, should a SoftDeletePropertyEvent be fired for each property? My inclination is to say no since we're really soft deleting the entire vertex.

Also, I've managed to kind of fix this on a branch but the possibility of this happening still exists. In the case where authorizations passed to softDeleteVertex or softDeleteEdge are not sufficient to see all of the properties, the ones that can't be seen will still be orphaned.

[joeferner]

RE SoftDeletePropertyEvent probably not.

What about the case when you restore the vertex, do the properties also come back?

[mwizeman]

Yes

1. Create a vertex with Prop1:VisibilityA and Prop2:VisibilityB
2. Load the vertex with AuthA
3. Soft delete the vertex
4. Create a new vertex with the same id
5. Load the vertex with AuthA and AuthB
6. The vertex will have Prop2:VisibilityB on it

[mwizeman]

@joeferner I just pushed my branch from earlier today in case you have any ideas on the visibility problem.