kvm-guest-drivers-windows icon indicating copy to clipboard operation
kvm-guest-drivers-windows copied to clipboard

viogpu: Allow combining DBG and WPP

Open akihikodaki opened this issue 8 months ago • 5 comments

Allow combining DBG and WPP by defining DBG and EVENT_TRACING at the same time.

akihikodaki avatar Mar 19 '25 12:03 akihikodaki

Can one of the admins verify this patch?

YanVugenfirer avatar Mar 19 '25 12:03 YanVugenfirer

test this please

YanVugenfirer avatar Mar 19 '25 14:03 YanVugenfirer

@akihikodaki I have a question (just a question): What is the motivation to define both DBG and WPP?

ybendito avatar Mar 22 '25 12:03 ybendito

@akihikodaki @ybendito Yeah, I also have the same question :) IIRC, the original intention was to enable WPP in release builds and keep DBG for the developers, if they need it. Did we change this approach recently?

All the best, Vadim.

vrozenfe avatar Mar 22 '25 21:03 vrozenfe

@ybendito @vrozenfe My use case is to debug a detached Arm64 system.

Setting DBG gives logs via COM or vDbgPrintEx and enables debug assertions using VIOGPU_ASSERT_CHK. The logging does not work for a detached Arm64 system because:

  • IO ports used for COM are not available on Arm64.
  • vDbgPrintEx works only when attached.

Combining DBG and WPP allows having logging and debug assertions at the same time on a detached Arm64 system.

akihikodaki avatar Mar 29 '25 07:03 akihikodaki

[Jenkins CI]: Can one of the admins verify this patch?

YanVugenfirer avatar Aug 15 '25 10:08 YanVugenfirer