react-sketch-canvas icon indicating copy to clipboard operation
react-sketch-canvas copied to clipboard

Firefox compatibility

Open yuchi328 opened this issue 4 years ago • 4 comments

Describe the bug Thanks for the new version release! I had an issue when using it on Firefox. It seems that the current version is not very compatible with Firefox, brush strokes are not displayed properly.

To Reproduce Run on Firefox browser, and draw.

Desktop (please complete the following information):

  • OS: MacOS
  • Browser: Firefox

yuchi328 avatar Oct 29 '21 08:10 yuchi328

I am having the same issue on Firefox with Fedora Linux. This issue doesn't occur with Google Chrome.

jsalgado2510 avatar Nov 01 '21 03:11 jsalgado2510

Looks like a performance issue due to rendering. I wanted to change the underlying data structure of CanvasPath to handle this in v7.

If anyone else figures out a simpler way of solving this, please make a PR

vinothpandian avatar Nov 09 '21 21:11 vinothpandian

Do you plan to work on this issue in the near future?

ivan-at-hypothetic avatar Aug 02 '22 12:08 ivan-at-hypothetic

@ivan-at-hypothetic Yes in the near future, but I didn't have much time to spend on it recently. However, if you have a fix, please send a PR.

vinothpandian avatar Aug 02 '22 15:08 vinothpandian

Hi everyone! Any news about this issue?

Fixed with 7.0.0.next.0 release

vinothpandian avatar Jan 16 '23 07:01 vinothpandian

Hey @vinothpandian. Unfortunately I think this bug still persists in the new version you mentioned.

Here's a repro video: https://www.loom.com/share/b804e56441d6494f96d24e83dd2634ed

zeke avatar Feb 28 '23 21:02 zeke

Here's how we're working around it: https://github.com/replicate/scribble-diffusion/issues/31#issuecomment-1451288647

zeke avatar Mar 03 '23 04:03 zeke

Thanks @zeke! Seems like the eraser is the problem. I will add a stroke eraser option where users can delete strokes as well.

vinothpandian avatar Mar 18 '23 00:03 vinothpandian