peerlist-readme-badge icon indicating copy to clipboard operation
peerlist-readme-badge copied to clipboard

[BUG] Changing the badge style doesn't update the badge

Open vinitshahdeo opened this issue 3 years ago • 5 comments

The badges should be updated when we change the badge style using the dropdown but it's not updating as expected. It's only updated when we click on the GENERATE CTA - it should be auto-updated on switching the style from the dropdown.

Please refer to the attached video or try it out here: peerlist-readme-badge.netlify.app.

https://user-images.githubusercontent.com/20594326/193805668-38875f56-e420-4884-8b15-3303217a1917.mov

Local development

The react app is available inside the client/ directory in the feature/web-app. Try it out here: peerlist-readme-badge.netlify.app

Follow the commands below to build locally 👇

git checkout feature/web-app
cd client/peerlist-readme-badge
npm install
npm run start

vinitshahdeo avatar Oct 04 '22 11:10 vinitshahdeo

@vinitshahdeo I want to work on this. Please assign it to me.

racky7 avatar Oct 04 '22 12:10 racky7

@vinitshahdeo Assign me this task, I'm a full stack developer and will get it done in no time

abhishekpatil4 avatar Oct 04 '22 15:10 abhishekpatil4

Hey @vinitshahdeo! I know how to solve this issue!! Can you please assign this task to me? Thank you

Jaivrat12 avatar Oct 05 '22 04:10 Jaivrat12

Hello, @vinitshahdeo I have fixed this bug. Please check my PR and merge.

Thanks

g1mishra avatar Oct 05 '22 08:10 g1mishra

@racky7 @abhishekpatil4 @Jaivrat12 @g1mishra - please take a look at #30

vinitshahdeo avatar Oct 10 '22 20:10 vinitshahdeo