css-loader
css-loader copied to clipboard
Missing CSS properties for `moon-around-light`
Hi, And thank you for this amazing work of art.
I tried to use this full moon with a spinning light around it in my code and I realized that you need to add display: inline-block and left: 0 to .loader::before to get it work.
I think you should update these lines here: https://github.com/vineethtrv/css-loader/blob/f51b9ae2cad53582f009240f04fd830142799328/js/loaders/circle.js#L1800-L1830
BTW I really think it is time to do a revision, things like the following were added for quite some time:
- CSS logical properties
- CSS nesting.
- And
:beforewere changed to::before(ref).
Since I raised the topic I guess I do not mind helping you out refactoring it.
[!NOTE] I am not saying to remove css declarations such as
widthentirely but I guess we can at least use the logical properties alongside physical, direction and dimension mappings. Maybe in a year or two we just could then get rid of them entirely.
Same here: https://github.com/vineethtrv/css-loader/blob/f51b9ae2cad53582f009240f04fd830142799328/js/loaders/circle.js#L2719-L2767
You need to add display: inline-block to your .loader class