vital.vim icon indicating copy to clipboard operation
vital.vim copied to clipboard

[RFC] Split vitalizer and modules into individual repositories

Open tyru opened this issue 7 years ago • 7 comments

via https://vim-jp.slackarchive.io/general/page-40/ts-1514306851000160

Repositories

See https://github.com/vim-jp/vital.vim/issues/568#issuecomment-354590388

  • ~~vim-jp/vital.vim - Vitalizer only~~
  • ~~vim-jp/vital-core.vim - Core modules~~
  • ~~vim-jp/vital-supplement.vim - Supplement modules~~

Vitalizer clones external repositories

  • Vitalize --repo=vim-jp/vital-core.vim {dir}
  • vim-jp/vital-core.vim is the default repository (does not have to specify it explicitly)
  • The specified repositories list are stored in autoload/vital/{name}.repo file so the next time users don't have to specify repositories twice
    • Can the list be written in autoload/vital/{name}.vital file with keeping the compatibility of the current format?

tyru avatar Dec 27 '17 01:12 tyru

The original reason why I started vital.vim both with vitalizer and modules in a same repository was just for convenience. I agree :+1: with splitting them if it helps our development significantly.

I guess it's also a time to create a vital.vim organization, either at https://github.com/vital or https://github.com/vitalvim (I hoped https://github.com/vital.vim was available though.)

  • vital/vital.vim - Vitalizer only
  • vital/vital-core.vim - Core modules that even vitalizer depends on
  • vital/vital-supplement.vim - Supplement modules (i.e. current vital.vim modules except for above)

ujihisa avatar Dec 31 '17 06:12 ujihisa

+1 for organization!

lambdalisue avatar Dec 31 '17 07:12 lambdalisue

organization 👍

However, I don't think vim prefix or suffix is necessary if organization name already has "vim".

  • vim-vital/vitalizer - Vitalizer only
  • vim-vital/vital-core - Core modules that even vitalizer depends on
  • vim-vital/vital-supplement - Supplement modules (i.e. current vital.vim modules except for above)

I think vital module repository should (not must) have "vital-" prefix, because it indicates "vital module" to vim or vital users (e.g.: webpack loader has "-loader" suffix).

tyru avatar Dec 31 '17 07:12 tyru

:Vitalize する際に毎回リポジトリを git clone するのか、またはキャッシュ用ディレクトリに置くとしたらどこに置くのか、といった事を決める必要があると思います。 例: ~/.vitalizer/cache/github.com/{user}/{repo}

tyru avatar Feb 27 '18 05:02 tyru

キャッシュ用ディレクトリはこの node モジュールと同じにすると良さそうです。 各プラットフォームで最適なディレクトリを探してくれてるっぽいです。 例えば Unix 系だったら ~/.cache/{appname} とか。

https://www.npmjs.com/package/cache-directory https://github.com/strugee/node-cache-directory/blob/master/index.js

参考

XDG Base Directory Specification https://standards.freedesktop.org/basedir-spec/latest/ar01s03.html

tyru avatar Mar 01 '18 01:03 tyru

多分リポジトリの存在も知らない人が多いと思うので、こっちからリンク貼って周知しておきます。 https://github.com/vim-vital/vital-core/issues/1

このリポジトリの経緯としては、 #577 の vital 開発者会議 2018-03 (参加者: @lambdalisue, @thinca, @ujihisa, @tyru) の時にこの issue の話が上がり、organization だけでも取っておこうという事になって作ったリポジトリです。 まだ移行も終わっていないため、このリポジトリで話し合いを進めていくのかどうかは検討の余地がありそうですが、とりあえず周知だけ。

tyru avatar Jun 11 '18 12:06 tyru

Translated above comment.


https://github.com/vim-vital/vital-core/issues/1 Maybe most people here don't know the organization & repository, I just want to share them.

The repository was created on vital developer meeting 2018-03 (participant: @lambdalisue, @thinca, @ujihisa, @tyru). This issue (#568) was discussed and we took the organization namespace then.

This is my personal opinion. I think it's necessary to discuss if we use there now. because we don't move the repository yet.

tyru avatar Jun 11 '18 12:06 tyru