Create VimlParser vital-module

[haya14busa]

trafficstars

Create vital-module interface of vimlparser. See https://github.com/vim-jp/vital.vim for vital-module.

By introducing vital-module, users can use vimlparser as vital-module and we can mitigate the migration problem of breaking changes.

[tyru]

Do we need to split some objects into each module?

• VimlParser
• VimlParser.StringReader
• VimlParser.Compiler
• ...

[haya14busa]

I don't want to introduce changes caused by making vimlparser vital-module. Users are expected to use import() method only.

[haya14busa]

Do we need to split some objects into each module?

We need to translate vimlparser.vim to python and javascript, so we cannot do this easily.

[tyru]

We need to translate vimlparser.vim to python and javascript

ah, I forgot that. thanks.

[codecov[bot]]

Codecov Report

Merging #74 into master will increase coverage by 0.36%. The diff coverage is n/a.

@@            Coverage Diff            @@
##           master     #74      +/-   ##
=========================================
+ Coverage   66.93%   67.3%   +0.36%     
=========================================
  Files           1       1              
  Lines        3590    3569      -21     
=========================================
- Hits         2403    2402       -1     
+ Misses       1187    1167      -20

Impacted Files	Coverage Δ
autoload/vital/__vimlparser__/VimLParser.vim	67.3% <ø> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ae76039...67cead6. Read the comment docs.

[haya14busa]

Test finally passed in travis CI! (Thanks to @thinca :+1:)

It's ready to review and merge. Can you take a look at this p-r? @mattn @tyru

[tyru]

• Change to autoload/vital/__vimlparser__/VimlParser.vim ? or remove them?

https://github.com/vim-jp/vim-vimlparser/blob/8c63d1a2bdf8f15960bfb5a5729c49cab319ea8f/scripts/update_builtin_commands.vim#L132 https://github.com/vim-jp/vim-vimlparser/blob/8c63d1a2bdf8f15960bfb5a5729c49cab319ea8f/scripts/update_builtin_commands.vim#L134

• is it confusing that module name is VimlParser, but class(object) name is VimLParser?

[haya14busa]

Thanks! Done.

[mattn]

Currently, VimLParser seems to export following functions. Is this your expected?

isalnum Node ExArg islower isnamec iswordc1 isdigit iswhite import isvarname isalpha Err isnamec1 isargname isupper isxdigit iswordc isodigit isidc

[haya14busa]

Yes, it's expected. I don't want to introduce changes caused by making it vital-module as much as possible. Also, the changes will be translated into other languages too and i feel a bit weird to add _ prefix to all script local functions.

s:import() should be only public API. I'll add comment.

[haya14busa]

s:import() should be only public API. I'll add comment.

Done. 67cead6b35cfbdc4ee375b1dd5fa2bde1121b50b

[ujihisa]

Besides that I believe this LGTM :sushi: as a vim-jp org but I prefer listening to other core devs voices.