indicator-kdeconnect icon indicating copy to clipboard operation
indicator-kdeconnect copied to clipboard

Published 20 hours ago • verified publisher icon vikoadi

KF5-based KDE Connect unsupported

Open KAMiKAZOW opened this issue 10 years ago • 7 comments

indicator-kdeconnect seems to not recognize the new KF5-based KDE Connect. I paired my phone from the KF5 KDE Connect KCM. The indicator says "paired but not reachable".

KAMiKAZOW avatar Jun 12 '15 00:06 KAMiKAZOW

A change we made recently broke the DBUS API, sorry and thanks for reporting it! It should be fixed now (see this commit: https://git.reviewboard.kde.org/r/124084/ ) Can you try again with the latest version in master (from the KDE repo, the Github mirror is not updated yet) and see if it's fixed?

@vikoadi It would be nice when you have time to update your code to use pairingChanged(bool paired) instead of pairedSuccessful() and unpaired(), so we can eventually remove these two (we added them back to not break API, but marked them as deprecated). It should be a simple change :)

albertvaka avatar Jun 12 '15 15:06 albertvaka

API restored, deprecated. http://commits.kde.org/kdeconnect-kde/ef788e065804383206137377ce740e967866f156

aleixpol avatar Jun 12 '15 15:06 aleixpol

@KAMiKAZOW KF5 branch should listen to pairingChanged by now, but as i don’t have KF5 desktop right now i need someone to verify

thanks everyone

vikoadi avatar Jun 13 '15 20:06 vikoadi

Good call creating a new branch! I didn't realize before but we need to make sure you don't need to break compatibility with users of the KDE4 version (which probably means most of our users). We will keep the "deprecated" versions long enough so you don't need to worry about this. Thanks!

albertvaka avatar Jun 14 '15 01:06 albertvaka

Forgot to build from the branch. Currently compiling. Will report tomorrow.

KAMiKAZOW avatar Jul 06 '15 02:07 KAMiKAZOW

We also changed the kdeconnect code to not break backwards compatibility (but deprecated the old API), so it should work anyway :P On Jul 5, 2015 7:41 PM, "Markus S." [email protected] wrote:

Forgot to build from the branch. Currently compiling. Will report tomorrow.

— Reply to this email directly or view it on GitHub https://github.com/vikoadi/indicator-kdeconnect/issues/20#issuecomment-118698373 .

albertvaka avatar Jul 06 '15 16:07 albertvaka

My devices are listed as "Paired but not reachable", using the KF5 branch by @vikoadi I don't think Fedora ships the modifications by @albertvaka yet.

KAMiKAZOW avatar Jul 07 '15 00:07 KAMiKAZOW