Vijayaditya Peddinti

Just an update: I have started this review, should be done by end of day.

I was able to start the review yesterday. I am going through Yiming's suggested changes (offline) before I give my suggestions. On Sat, Mar 5, 2016 at 12:23 AM, Daniel...

@freewym could you resolve the conflicts ? An easy way to do this would be to rebase your branch with the master.

@freewym what is the status of this PR? Is it ready for review ?

I am stopping the review. Will resume after you make required changes or justify why these changes are not necessary.

OK will review in few hours. On Tue, Mar 15, 2016 at 8:19 PM, Yiming Wang [email protected] wrote: > Moved the comments in the braces. @vijayaditya > https://github.com/vijayaditya I am...

@freewym I might not be able to review this till Saturday. In the mean time could you please add the unit tests for the decodable object and egs creation code...

I was able to perform a cursory check. I think you should start an experiment and compare the performance with baseline (one ivector/chunk). You can create a new script based...

@vimalmanohar I have created the package structure according to our discussion.

@freewym Would you be able to help in this PR ? You might be maintaining these scripts in the future so it would be good to familiarize yourself. Could you...