Viggo de Vries comments

Results 26 comments of


                                            Viggo de Vries

Fix a typo which caused a typeerror on string formatting

@Thomasvdh92 tests failing unfortunately.

Fix typo max_basket_applications

wow, please add a test to check this specific condition.

fix: call _fetch_item from _process_image for easier override

hi @Chadys thanks for your contributions! We actually never use this Importer in production. see: https://github.com/django-oscar/django-oscar/blob/master/src/oscar/apps/catalogue/utils.py#L25 so I don't think will merge this. Recently I have been working on a...

ProductAttributeValue can see all values across all attribute groups

So there is a clean method being done in the product attrbutes, I think this is what you mean https://github.com/django-oscar/django-oscar/blob/master/src/oscar/apps/catalogue/abstract_models.py#L1190 BUT, load data does NOT run clean on the models....

fixed zipcode ordering

I think this is really country specific is it not? In the Netherlands, yes we want this order, but for other countries it may be different. what could be useful...

setup: make npm build optional

why would you build from the distribution package?