libdsm icon indicating copy to clipboard operation
libdsm copied to clipboard

Merge from Artem's fork

Open jbkempf opened this issue 8 years ago • 11 comments

This needs reviewing :)

jbkempf avatar Mar 07 '17 10:03 jbkempf

Well, in fact, most of it is not good. But there are a couple of things to cherry-pick.

jbkempf avatar Mar 07 '17 10:03 jbkempf

@elthariel no, most of the branch is very bad. There is an interesting patch about move(), but the rest is almost all useless...

jbkempf avatar Apr 25 '17 15:04 jbkempf

There's also the asn1 thread safety part which is good

elthariel avatar Apr 25 '17 15:04 elthariel

and the logoff

elthariel avatar Apr 25 '17 15:04 elthariel

@elthariel then we should cherry-pick those :)

jbkempf avatar May 08 '17 15:05 jbkempf

Yeah. I started to have a look by but that won't be easy

On Mon, May 8, 2017, 17:41 Jean-Baptiste Kempf [email protected] wrote:

@elthariel https://github.com/elthariel then we should cherry-pick those :)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/videolabs/libdsm/pull/105#issuecomment-299904782, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJa866DdOKNBtDl4jlTmKawE8xbPmEfks5r3zfEgaJpZM4MVSR0 .

elthariel avatar May 09 '17 07:05 elthariel

@Kxuan do you now what we must cherry-pick?

jbkempf avatar Jul 31 '17 11:07 jbkempf

@jbkempf acturally, I dont known.. There are too many commits that I do not need. I just merge the 40c2404 to my fork...

Kxuan avatar Jul 31 '17 11:07 Kxuan

@Kxuan what is there in your fork? Just 40c2404 ?

jbkempf avatar Jul 31 '17 12:07 jbkempf

Yes. Only 4e226691e7359d798415dc09c7c901d9370ed666 is picked

Kxuan avatar Jul 31 '17 12:07 Kxuan

4e22669 has been merged

chouquette avatar Aug 28 '17 12:08 chouquette