mui-tel-input icon indicating copy to clipboard operation
mui-tel-input copied to clipboard

Add React 19 as peer-dependency

Open ruiaraujo012 opened this issue 11 months ago • 13 comments
trafficstars

Now that react 19 is stable, you should add it as a peer dep.

└─┬ mui-tel-input 7.0.0
  ├── ✕ unmet peer @types/react@^18.0.0: found 19.0.1
  ├── ✕ unmet peer react@^18.0.0: found 19.0.0
  └── ✕ unmet peer react-dom@^18.0.0: found 19.0.0

Thanks.

ruiaraujo012 avatar Dec 13 '24 08:12 ruiaraujo012

I don't recommend to update your MUI project to React 19 before https://github.com/mui/material-ui/issues/42381 is completed.

I will wait until is done and then, I will add the compatibility.

viclafouch avatar Dec 15 '24 16:12 viclafouch

Hi @viclafouch, MUI now supports React 19. When can we expect a new release?

voi99 avatar Dec 20 '24 17:12 voi99

Hi @viclafouch, when can you update the lib for React 19 please ?

Didi3333 avatar Jan 08 '25 16:01 Didi3333

Hello here !

First, happy new year everyone ! 🤩

Just to let you know, that one library is missing on my side to upgrade to React 19 : Storybook.

Storybook and mainly types are incompatible with React 19. The storybook team are working on it :

  • https://github.com/storybookjs/storybook/issues/30104
  • https://github.com/storybookjs/storybook/issues/29805#issuecomment-2580427203
  • https://github.com/storybookjs/storybook/pull/30031

I know it's just Storybook, but it can be difficult for me if I need to work on my storybook and having issues with types.

I've subscribed to the storybook PRs. I think it's just a question of days..

When it will be fixed, I will immedialty upgrade React 19 here for mui-tel-input.

For now, you can --force without any problem.

viclafouch avatar Jan 09 '25 16:01 viclafouch

Hey! Using --force is working well for me, however, I'm not able to deploy to Heroku this way. Is there any update on adding React 19 support?

yellowstrings avatar Jan 28 '25 21:01 yellowstrings

Hey! Using --force is working well for me, however, I'm not able to deploy to Heroku this way. Is there any update on adding React 19 support?

Your build instructions need to be changed to accommodate the --force argument. It's not generally recommended because if you don't take it off, this might cause issues with other packages in the future.

mrjackyliang avatar Jan 28 '25 23:01 mrjackyliang

Oh thank you so much! I'll look into that!

yellowstrings avatar Jan 28 '25 23:01 yellowstrings

Hi, I have a React app and I'm using yarn as package manager. I get the following warning when I execute yarn install:

➤ YN0060: │ @types/react is listed by your project with version 19.0.8 (p87fc6), which doesn't satisfy what mui-tel-input (via @myorg/my-package) and other dependencies request (^18.2.25).
➤ YN0060: │ react is listed by your project with version 19.0.0 (p6c43b), which doesn't satisfy what mui-tel-input (via @myorg/my-package) and other dependencies request (but they have non-overlapping ranges!).
➤ YN0060: │ react-dom is listed by your project with version 19.0.0 (p9228c), which doesn't satisfy what mui-tel-input (via @myorg/my-package) and other dependencies request (but they have non-overlapping ranges!).

Tried with yarn resolutions (https://yarnpkg.com/cli/set/resolution) but I didn't find a way to force correct version

How can I solve this problem?

Many thanks in advance.

Mauro

mauro-ni avatar Jan 31 '25 08:01 mauro-ni

React 19 support has been added to Storybook in version 8.5.

https://github.com/storybookjs/storybook/releases/tag/v8.5.0

nms2019 avatar Jan 31 '25 14:01 nms2019

Yes, looks like we're ready to upgrade ! Will be this week !! 👍

viclafouch avatar Feb 03 '25 17:02 viclafouch

Hey all ! As u can see here : https://github.com/storybookjs/storybook/releases/tag/v8.6.0-alpha.3

Core: Improve type compatibility with React 19 - https://github.com/storybookjs/storybook/pull/30031, thanks @mrginglymus!

The fix has been merged, but the version is not stable yet. (Soon soon)

viclafouch avatar Feb 07 '25 19:02 viclafouch

Looks like Storybook is now stable with 8.5.2 and React 19:

Image

nms2019 avatar Feb 18 '25 17:02 nms2019

Looks like Storybook is now stable with 8.5.2 and React 19:

Image

Nah, we have to wait for 8.6. They still have types issues.

viclafouch avatar Feb 19 '25 11:02 viclafouch

Don't want to rush you in any way but just saw the version is released now: https://github.com/storybookjs/storybook/releases/tag/v8.6.0

lukas-cc avatar Feb 25 '25 11:02 lukas-cc

Can we expect release this week?

krdzex avatar Feb 28 '25 18:02 krdzex

Fixed in https://github.com/viclafouch/mui-tel-input/releases/tag/v8.0.0 !

Thanks everyone ! 🤩

viclafouch avatar Feb 28 '25 22:02 viclafouch