nebula
nebula copied to clipboard
fix. date validator will reject 00 in day part.
the validateDate impl only checks the overflow of day part, which allows input like DATE("2024-07-00"). this will lead to error in reading process.
What type of PR is this?
- [x] bug
- [ ] feature
- [ ] enhancement
What problem(s) does this PR solve?
Issue(s) number:
Description:
the `validateDate` impl only checks the overflow of day part,
which allows input like DATE("2024-07-00"). this will lead to
error in the reading process.
How do you solve it?
add check in `validateDate`
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
- [x] Unit test(positive and negative cases)
- [ ] Function test
- [ ] Performance test
- [ ] N/A
Affects:
- [ ] Documentation affected (Please add the label if documentation needs to be modified.)
- [ ] Incompatibility (If it breaks the compatibility, please describe it and add the label.)
- [ ] If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
- [ ] Performance impacted: Consumes more CPU/Memory
Release notes:
Please confirm whether to be reflected in release notes and how to describe:
ex. Fixed the bug .....