vertica-kubernetes icon indicating copy to clipboard operation
vertica-kubernetes copied to clipboard

parse serviceName in VerticaReplicator

Open fenic-fawkes opened this issue 1 year ago • 6 comments

allow users to provide a service name to use for source and target databases. if unspecified we use the first service assigned to the database with a cluster ip, if supplied we validate that it's assigned to the appropriate main/sandbox cluster

fenic-fawkes avatar Jun 03 '24 15:06 fenic-fawkes

We should also update e2e test. Let's discuss about this at the standup.

roypaulin avatar Jun 07 '24 11:06 roypaulin

_ No description provided. _

Could we update the PR description please?

jizhuoyu avatar Jun 10 '24 15:06 jizhuoyu

needs one small vcluster change that's under review but then this should be good to merge

fenic-fawkes avatar Jun 13 '24 19:06 fenic-fawkes

I've synced the vclusterOps to the Github repository. You can update your go.mod to refer to the latest commit in vcluster repo.

cchen-vertica avatar Jun 17 '24 15:06 cchen-vertica

Almost done! Resolve the conflicts and run the tests again.

roypaulin avatar Jun 26 '24 10:06 roypaulin

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
5 out of 6 committers have signed the CLA.

:white_check_mark: jizhuoyu
:white_check_mark: chinhtranvan
:white_check_mark: cchen-vertica
:white_check_mark: roypaulin
:white_check_mark: fenic-fawkes
:x: spilchen


spilchen seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jul 25 '24 03:07 CLAassistant