vertx-rx icon indicating copy to clipboard operation
vertx-rx copied to clipboard

Added Vert.x Oracle Client

Open tsegismont opened this issue 3 years ago • 6 comments

Oracle Client Rx bindings are not present in the stack yet

tsegismont avatar Dec 21 '21 15:12 tsegismont

The build fails because, when using JDK8, the classes of the Reactive Oracle Client cannot be read. Indeed, the module is built with JDK11:

            <configuration>
              <toolchains>
                <jdk>
                  <version>11</version>
                </jdk>
              </toolchains>
            </configuration>

@vietj I know the Oracle JDBC driver requires Java 11+ at runtime but have we tried to build the module with JDK8 and run tests only when JDK11+ is used?

That would help solve this stack integration issue as well as the Kotlin one: https://github.com/vert-x3/vertx-lang-kotlin/pull/215

tsegismont avatar Jan 11 '22 16:01 tsegismont

that is not possible because Oracle jar is compiled with bytecode of Java 11+

vietj avatar Jan 12 '22 08:01 vietj

toolchain requires a specific configuration in the .m2 file and install an extra JDK, we could try to support it in this GitHub action.

vietj avatar Jan 12 '22 08:01 vietj

Thanks for tip. I'll give it a try when we work on 4.3

tsegismont avatar Jan 12 '22 09:01 tsegismont

ping @tsegismont

vietj avatar May 18 '22 06:05 vietj

@vietj PTAL

The second commit message gives some details about the changes

tsegismont avatar Sep 30 '22 09:09 tsegismont