vertx-dropwizard-metrics icon indicating copy to clipboard operation
vertx-dropwizard-metrics copied to clipboard

Make reservoir configurable

Open venikkin opened this issue 7 years ago • 1 comments

Reservoir used in internal meters (e.g. ThroughputMeter) is hardcoded to the default ExponentiallyDecayingReservoir. Although it's possible to provide MetricRegistry implementation working with any other reservoir, internal meters still will be using default one. I suggest a PR #82 allowing specifying reservoir factory. Added only java way to set the factory so far.

Appreciate your feedback. Thanks

venikkin avatar Nov 25 '18 12:11 venikkin

I had a look at your PR. If we make the reservoir type configurable, I believe it should be per-metric.

tsegismont avatar Nov 26 '18 14:11 tsegismont