turbo icon indicating copy to clipboard operation
turbo copied to clipboard

Colors are not preserved, code lines are not clickable

Open MickL opened this issue 1 year ago • 7 comments

Verify canary release

  • [X] I verified that the issue exists in the latest Turborepo canary release.

Link to code that reproduces this issue

What package manager are you using / does the bug impact?

npm

What operating system are you using?

Mac

Which canary version will you have in your reproduction?

2.0.3

Describe the Bug

When I run "bun lint" normally I can click the line of code and it jumps into it (using Webstorm). Also the warning is yellow and an error would be red:

338527936-be1c9902-2466-43c3-bfd4-450aea7193da

If I run the same with Turbo (same with ui: "stream") I cant click the line and the color is lost aswell:

338528607-10c68e50-58e2-40cd-8aae-1ffe0b462627

Tested in iTerm and Webstorm

Apperently the colors have been fixed with #223 but maybe since the new UI has landed they are gone again?

Expected Behavior

To Reproduce

Additional context

No response

MickL avatar Jun 11 '24 15:06 MickL

@MickL I've had the same issue with Webstorm. With turbo v1 --log-prefix=none was enough, but with v2 I also have to disable the tui.

So typically for me this allow Webstorm to parse the lines and make them "clickable":

TURBO_UI=0 turbo run lint --log-prefix=none

It is not ideal but it is very convenient in dev.

jraoult avatar Jun 11 '24 17:06 jraoult

@MickL I've had the same issue with Webstorm. With turbo v1 --log-prefix=none was enough, but with v2 I also have to disable the tui.

So typically for me this allow Webstorm to parse the lines and make them "clickable":

TURBO_UI=0 turbo run lint --log-prefix=none

It is not ideal but it is very convenient in dev.

I'm seeing this issue in Warp as well after moving to turbo v2.

jskrable avatar Jun 12 '24 15:06 jskrable

TURBO_UI=0 

Works well for me when lauching build command ! Thanks for the tip

natacharome avatar Jun 13 '24 15:06 natacharome

Can people experiencing this try out 2.0.4-canary.4? chalk depends on some environment variables that weren't being passed through in strict mode. I've added these to the allowlist.

If the issue persists, then please provide the underlying tool you're using along with the values of TERM and COLORTERM in your shell.

chris-olszewski avatar Jun 13 '24 23:06 chris-olszewski

@chris-olszewski just to be clear, because I realise this can be confusing since this issue mentions two problems (that may be unrelated): from my side I can see the colours but the link to the code doesn't work.

With that in mind, I tried 2.0.4-canary.4 and sadly no improvement for me for the linking part.

My env: echo $TERM yields xterm-256color (and no COLORTERM for me).

jraoult avatar Jun 14 '24 10:06 jraoult

I tried 2.0.4-canary.4 within Webstorm and I see colors now :) Just lines of code are not clickable still

Bildschirmfoto 2024-06-14 um 14 17 27

MickL avatar Jun 14 '24 12:06 MickL

Workaround that seems to work for me to enable colors is to set FORCE_COLOR. Given the changes to strict mode in v2, you'll need to make sure to add it to globalPassThroughEnv.

nsimonson avatar Jun 14 '24 16:06 nsimonson