next.js icon indicating copy to clipboard operation
next.js copied to clipboard

Refactor Next.js CLI to use Commander

Open samcx opened this issue 1 year ago • 2 comments

Description

...

Changes

...

Closes NEXT-2293

samcx avatar Jan 29 '24 22:01 samcx

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@commander-js/[email protected] Transitive: environment, filesystem, shell +1 225 kB shadowspawn
npm/[email protected] environment, filesystem, shell 0 177 kB abetomo

View full report↗︎

socket-security[bot] avatar Jan 29 '24 22:01 socket-security[bot]

Failing test suites

Commit: 706d9d95da6eda53c6c5f950745f332cbbde146a

pnpm test-dev test/development/acceptance/component-stack.test.ts

  • Component Stack in error overlay > should show a component stack on hydration error
Expand output

● Component Stack in error overlay › should show a component stack on hydration error

thrown: "Exceeded timeout of 120000 ms for a hook.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  240 |   let next: NextInstance
  241 |   if (!skipped) {
> 242 |     beforeAll(async () => {
      |     ^
  243 |       next = await createNext(options)
  244 |     })
  245 |     afterAll(async () => {

  at beforeAll (lib/e2e-utils.ts:242:5)
  at nextTestSetup (lib/e2e-utils.ts:302:21)
  at describe (lib/e2e-utils.ts:301:3)
  at Object.<anonymous> (development/acceptance/component-stack.test.ts:6:19)

● Test suite failed to run

thrown: "Exceeded timeout of 120000 ms for a hook.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  115 |
  116 | if (typeof afterAll === 'function') {
> 117 |   afterAll(async () => {
      |   ^
  118 |     if (nextInstance) {
  119 |       await nextInstance.destroy()
  120 |       throw new Error(

  at Object.afterAll (lib/e2e-utils.ts:117:3)
  at Object.<anonymous> (development/acceptance/component-stack.test.ts:5:19)

Read more about building and testing Next.js in contributing.md.

pnpm test-dev test/development/acceptance-app/rsc-runtime-errors.test.ts

  • Error overlay - RSC runtime errors > should show runtime errors if invalid client API from node_modules is executed
  • Error overlay - RSC runtime errors > should show runtime errors if invalid server API from node_modules is executed
  • Error overlay - RSC runtime errors > should show source code for jsx errors from server component
  • Error overlay - RSC runtime errors > should show the userland code error trace when fetch failed error occurred
  • Error overlay - RSC runtime errors > should contain nextjs version check in error overlay
Expand output

● Error overlay - RSC runtime errors › should show runtime errors if invalid client API from node_modules is executed

thrown: "Exceeded timeout of 120000 ms for a hook.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  240 |   let next: NextInstance
  241 |   if (!skipped) {
> 242 |     beforeAll(async () => {
      |     ^
  243 |       next = await createNext(options)
  244 |     })
  245 |     afterAll(async () => {

  at beforeAll (lib/e2e-utils.ts:242:5)
  at nextTestSetup (lib/e2e-utils.ts:302:21)
  at describe (lib/e2e-utils.ts:301:3)
  at Object.<anonymous> (development/acceptance-app/rsc-runtime-errors.test.ts:14:19)

● Error overlay - RSC runtime errors › should show runtime errors if invalid server API from node_modules is executed

thrown: "Exceeded timeout of 120000 ms for a hook.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  240 |   let next: NextInstance
  241 |   if (!skipped) {
> 242 |     beforeAll(async () => {
      |     ^
  243 |       next = await createNext(options)
  244 |     })
  245 |     afterAll(async () => {

  at beforeAll (lib/e2e-utils.ts:242:5)
  at nextTestSetup (lib/e2e-utils.ts:302:21)
  at describe (lib/e2e-utils.ts:301:3)
  at Object.<anonymous> (development/acceptance-app/rsc-runtime-errors.test.ts:14:19)

● Error overlay - RSC runtime errors › should show source code for jsx errors from server component

thrown: "Exceeded timeout of 120000 ms for a hook.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  240 |   let next: NextInstance
  241 |   if (!skipped) {
> 242 |     beforeAll(async () => {
      |     ^
  243 |       next = await createNext(options)
  244 |     })
  245 |     afterAll(async () => {

  at beforeAll (lib/e2e-utils.ts:242:5)
  at nextTestSetup (lib/e2e-utils.ts:302:21)
  at describe (lib/e2e-utils.ts:301:3)
  at Object.<anonymous> (development/acceptance-app/rsc-runtime-errors.test.ts:14:19)

● Error overlay - RSC runtime errors › should show the userland code error trace when fetch failed error occurred

thrown: "Exceeded timeout of 120000 ms for a hook.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  240 |   let next: NextInstance
  241 |   if (!skipped) {
> 242 |     beforeAll(async () => {
      |     ^
  243 |       next = await createNext(options)
  244 |     })
  245 |     afterAll(async () => {

  at beforeAll (lib/e2e-utils.ts:242:5)
  at nextTestSetup (lib/e2e-utils.ts:302:21)
  at describe (lib/e2e-utils.ts:301:3)
  at Object.<anonymous> (development/acceptance-app/rsc-runtime-errors.test.ts:14:19)

● Error overlay - RSC runtime errors › should contain nextjs version check in error overlay

thrown: "Exceeded timeout of 120000 ms for a hook.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  240 |   let next: NextInstance
  241 |   if (!skipped) {
> 242 |     beforeAll(async () => {
      |     ^
  243 |       next = await createNext(options)
  244 |     })
  245 |     afterAll(async () => {

  at beforeAll (lib/e2e-utils.ts:242:5)
  at nextTestSetup (lib/e2e-utils.ts:302:21)
  at describe (lib/e2e-utils.ts:301:3)
  at Object.<anonymous> (development/acceptance-app/rsc-runtime-errors.test.ts:14:19)

● Test suite failed to run

thrown: "Exceeded timeout of 120000 ms for a hook.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  115 |
  116 | if (typeof afterAll === 'function') {
> 117 |   afterAll(async () => {
      |   ^
  118 |     if (nextInstance) {
  119 |       await nextInstance.destroy()
  120 |       throw new Error(

  at Object.afterAll (lib/e2e-utils.ts:117:3)
  at Object.<anonymous> (development/acceptance-app/rsc-runtime-errors.test.ts:7:19)

Read more about building and testing Next.js in contributing.md.

pnpm test-dev test/development/app-dir/hmr-move-file/hmr-move-file.test.ts

  • HMR Move File > should work when moving a component to another directory
Expand output

● HMR Move File › should work when moving a component to another directory

thrown: "Exceeded timeout of 120000 ms for a hook.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  240 |   let next: NextInstance
  241 |   if (!skipped) {
> 242 |     beforeAll(async () => {
      |     ^
  243 |       next = await createNext(options)
  244 |     })
  245 |     afterAll(async () => {

  at beforeAll (lib/e2e-utils.ts:242:5)
  at nextTestSetup (lib/e2e-utils.ts:302:21)
  at describe (lib/e2e-utils.ts:301:3)
  at Object.<anonymous> (development/app-dir/hmr-move-file/hmr-move-file.test.ts:4:19)

● Test suite failed to run

thrown: "Exceeded timeout of 120000 ms for a hook.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  115 |
  116 | if (typeof afterAll === 'function') {
> 117 |   afterAll(async () => {
      |   ^
  118 |     if (nextInstance) {
  119 |       await nextInstance.destroy()
  120 |       throw new Error(

  at Object.afterAll (lib/e2e-utils.ts:117:3)
  at Object.<anonymous> (development/app-dir/hmr-move-file/hmr-move-file.test.ts:5:19)

Read more about building and testing Next.js in contributing.md.

pnpm test-dev test/e2e/app-dir/app-basepath/index.test.ts (PPR)

  • app dir - basepath > should successfully hard navigate from pages -> app
  • app dir - basepath > should support basePath
  • app dir - basepath > should support Link with basePath prefixed
  • app dir - basepath > should prefix metadata og image with basePath
  • app dir - basepath > should prefix redirect() with basePath
  • app dir - basepath > should render usePathname without the basePath
Expand output

● app dir - basepath › should successfully hard navigate from pages -> app

thrown: "Exceeded timeout of 120000 ms for a hook.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  240 |   let next: NextInstance
  241 |   if (!skipped) {
> 242 |     beforeAll(async () => {
      |     ^
  243 |       next = await createNext(options)
  244 |     })
  245 |     afterAll(async () => {

  at beforeAll (lib/e2e-utils.ts:242:5)
  at nextTestSetup (lib/e2e-utils.ts:302:21)
  at describe (lib/e2e-utils.ts:301:3)
  at Object.<anonymous> (e2e/app-dir/app-basepath/index.test.ts:4:19)

● app dir - basepath › should support basePath

thrown: "Exceeded timeout of 120000 ms for a hook.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  240 |   let next: NextInstance
  241 |   if (!skipped) {
> 242 |     beforeAll(async () => {
      |     ^
  243 |       next = await createNext(options)
  244 |     })
  245 |     afterAll(async () => {

  at beforeAll (lib/e2e-utils.ts:242:5)
  at nextTestSetup (lib/e2e-utils.ts:302:21)
  at describe (lib/e2e-utils.ts:301:3)
  at Object.<anonymous> (e2e/app-dir/app-basepath/index.test.ts:4:19)

● app dir - basepath › should support Link with basePath prefixed

thrown: "Exceeded timeout of 120000 ms for a hook.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  240 |   let next: NextInstance
  241 |   if (!skipped) {
> 242 |     beforeAll(async () => {
      |     ^
  243 |       next = await createNext(options)
  244 |     })
  245 |     afterAll(async () => {

  at beforeAll (lib/e2e-utils.ts:242:5)
  at nextTestSetup (lib/e2e-utils.ts:302:21)
  at describe (lib/e2e-utils.ts:301:3)
  at Object.<anonymous> (e2e/app-dir/app-basepath/index.test.ts:4:19)

● app dir - basepath › should prefix metadata og image with basePath

thrown: "Exceeded timeout of 120000 ms for a hook.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  240 |   let next: NextInstance
  241 |   if (!skipped) {
> 242 |     beforeAll(async () => {
      |     ^
  243 |       next = await createNext(options)
  244 |     })
  245 |     afterAll(async () => {

  at beforeAll (lib/e2e-utils.ts:242:5)
  at nextTestSetup (lib/e2e-utils.ts:302:21)
  at describe (lib/e2e-utils.ts:301:3)
  at Object.<anonymous> (e2e/app-dir/app-basepath/index.test.ts:4:19)

● app dir - basepath › should prefix redirect() with basePath

thrown: "Exceeded timeout of 120000 ms for a hook.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  240 |   let next: NextInstance
  241 |   if (!skipped) {
> 242 |     beforeAll(async () => {
      |     ^
  243 |       next = await createNext(options)
  244 |     })
  245 |     afterAll(async () => {

  at beforeAll (lib/e2e-utils.ts:242:5)
  at nextTestSetup (lib/e2e-utils.ts:302:21)
  at describe (lib/e2e-utils.ts:301:3)
  at Object.<anonymous> (e2e/app-dir/app-basepath/index.test.ts:4:19)

● app dir - basepath › should render usePathname without the basePath

thrown: "Exceeded timeout of 120000 ms for a hook.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  240 |   let next: NextInstance
  241 |   if (!skipped) {
> 242 |     beforeAll(async () => {
      |     ^
  243 |       next = await createNext(options)
  244 |     })
  245 |     afterAll(async () => {

  at beforeAll (lib/e2e-utils.ts:242:5)
  at nextTestSetup (lib/e2e-utils.ts:302:21)
  at describe (lib/e2e-utils.ts:301:3)
  at Object.<anonymous> (e2e/app-dir/app-basepath/index.test.ts:4:19)

● Test suite failed to run

thrown: "Exceeded timeout of 120000 ms for a hook.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  115 |
  116 | if (typeof afterAll === 'function') {
> 117 |   afterAll(async () => {
      |   ^
  118 |     if (nextInstance) {
  119 |       await nextInstance.destroy()
  120 |       throw new Error(

  at Object.afterAll (lib/e2e-utils.ts:117:3)
  at Object.<anonymous> (e2e/app-dir/app-basepath/index.test.ts:5:19)

Read more about building and testing Next.js in contributing.md.

pnpm test-dev test/e2e/app-dir/actions/app-action-progressive-enhancement.test.ts (PPR)

  • app-dir alias > should handle typescript paths alias correctly
  • app-dir alias > should resolve css imports from outside with src folder presented
Expand output

● app-dir alias › should handle typescript paths alias correctly

thrown: "Exceeded timeout of 120000 ms for a hook.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  240 |   let next: NextInstance
  241 |   if (!skipped) {
> 242 |     beforeAll(async () => {
      |     ^
  243 |       next = await createNext(options)
  244 |     })
  245 |     afterAll(async () => {

  at beforeAll (lib/e2e-utils.ts:242:5)
  at nextTestSetup (lib/e2e-utils.ts:302:21)
  at describe (lib/e2e-utils.ts:301:3)
  at Object.<anonymous> (e2e/app-dir/app-alias/app-alias.test.ts:3:19)

● app-dir alias › should resolve css imports from outside with src folder presented

thrown: "Exceeded timeout of 120000 ms for a hook.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  240 |   let next: NextInstance
  241 |   if (!skipped) {
> 242 |     beforeAll(async () => {
      |     ^
  243 |       next = await createNext(options)
  244 |     })
  245 |     afterAll(async () => {

  at beforeAll (lib/e2e-utils.ts:242:5)
  at nextTestSetup (lib/e2e-utils.ts:302:21)
  at describe (lib/e2e-utils.ts:301:3)
  at Object.<anonymous> (e2e/app-dir/app-alias/app-alias.test.ts:3:19)

● Test suite failed to run

thrown: "Exceeded timeout of 120000 ms for a hook.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  115 |
  116 | if (typeof afterAll === 'function') {
> 117 |   afterAll(async () => {
      |   ^
  118 |     if (nextInstance) {
  119 |       await nextInstance.destroy()
  120 |       throw new Error(

  at Object.afterAll (lib/e2e-utils.ts:117:3)
  at Object.<anonymous> (e2e/app-dir/app-alias/app-alias.test.ts:5:19)

Read more about building and testing Next.js in contributing.md.

ijjk avatar Jan 29 '24 22:01 ijjk

Closing this branch for now so I can try using https://graphite.dev/ to stack :pr:s. Will still be working on this!

samcx avatar Feb 05 '24 23:02 samcx