next-learn icon indicating copy to clipboard operation
next-learn copied to clipboard

Chapter 8: Mismatch between sample code and documentation

Open nyatinte opened this issue 1 year ago • 0 comments

I noticed a discrepancy between the documentation in Chapter 8 and the sample code provided.

In the Chapter 8 Static and Dynamic Rendering - Simulating a Slow Data Fetch section of the documentation, it states "We artificially delay a response for demo purposes." However, if you check the actual sample code in this GitHub repository, this comment is slightly different

Chapter 8 Static and Dynamic Rendering - Simulating a Slow Data Fetch: /app/lib/data.ts

https://github.com/vercel/next-learn/blob/646898bc52d2bc22be9019871cf111e31b29d147/dashboard/starter-example/app/lib/data.ts#L18

This is a minor difference, but aligning the documentation with the sample code will increase clarity and consistency for those learning with this resource.

If it is more appropriate to update the sample code, I will be happy to create a pull request with the necessary changes.

Thank you for providing such a valuable learning resource!

nyatinte avatar Jan 23 '24 09:01 nyatinte