next-learn icon indicating copy to clipboard operation
next-learn copied to clipboard

Remove unused getUser

Open 2wheeh opened this issue 1 year ago • 2 comments

getUser implementation got moved to @app/lib/data:

  • #212

However, during the update of auth.ts, somehow getUser got decided to retained in auth.ts (which might be a result of a git conflict or intended to bundle seperatly)

  • #219

and the one that moved in @app/lib/data was not removed.

  1. getUser in the @app/lib/data is no longer in use.
  2. Chapter 15 describes upon the one in auth.ts

Therefore, shouldn't we remove the unused one left in @app/lib/data unless it was unintentional ? or we could consider removing the one in auth.ts with updating Chapter 15 mdx (don't forget to update type assertion to generic.)

In any case, one of them should be removed.

Thank you for the amazing course.

2wheeh avatar Dec 30 '23 07:12 2wheeh

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
next-learn-starter ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 30, 2023 7:56am
next-seo-starter ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 30, 2023 7:56am

vercel[bot] avatar Dec 30 '23 07:12 vercel[bot]

@2wheeh is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Dec 30 '23 07:12 vercel[bot]