next-learn icon indicating copy to clipboard operation
next-learn copied to clipboard

Dependency change to smoothen deployment

Open Priyansh4444 opened this issue 8 months ago • 5 comments

#1023
Multiple users include my friend were facing an issue regarding deployment with bcrypt, I think since this is a tutorial and only for learning purposes using bcryptjs for now is fine, since it is stable and does not cause an error.

Priyansh4444 avatar Mar 15 '25 08:03 Priyansh4444

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
next-learn-starter ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 15, 2025 8:23am
next-seo-starter ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 15, 2025 8:23am

vercel[bot] avatar Mar 15 '25 08:03 vercel[bot]

@Priyansh4444 is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Mar 15 '25 08:03 vercel[bot]

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] None 0 112 kB dcode

View full report↗︎

socket-security[bot] avatar Mar 15 '25 08:03 socket-security[bot]

I and other individuals have tried this approach and it does build on vercel but the resulting site's login process fails with a 404 error. Fixing the core issue (building the required packages....bcrypt and sharp) is the better solution than switching to bcryptjs.

There should really be a step in the tutorial that prompts the user to run the approve-builds pnpm command as suggested.

@Priyansh4444 Did you test the login on vercel after deployment to confirm that it works?

PR #1016 already addresses this fix.

w0244079 avatar Mar 19 '25 12:03 w0244079

Admittedly, I only tested this via localhost on my friends laptop that worked and glad the issue was resolved, this pr can be closed but do agree with confirmation before deployment!

Priyansh4444 avatar Mar 19 '25 17:03 Priyansh4444