vector icon indicating copy to clipboard operation
vector copied to clipboard

enhancement(gcp_cloud_storage): Make API endpoint configurable

Open movinfinex opened this issue 1 year ago • 1 comments

Closes https://github.com/vectordotdev/vector/issues/21137

Adds an endpoint config parameter, following the same pattern as other sources/sinks.

movinfinex avatar Aug 27 '24 05:08 movinfinex

CLA assistant check
All committers have signed the CLA.

bits-bot avatar Aug 27 '24 05:08 bits-bot

@neko-dd @jszwedko I think the integration tests should be good now. PTAL.

ghost avatar Sep 10 '24 03:09 ghost

Regression Detector Results

Run ID: 54176e4e-bd49-451d-81cd-b72854ee7fb2 Metrics dashboard

Baseline: 7086dfc147b2ea069cd6952437bb07a65b657730 Comparison: 03b33721e4137f628d12b16c20415c00fc8f28c6

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

Significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

perf experiment goal Δ mean % Δ mean % CI links
socket_to_socket_blackhole ingress throughput -6.22 [-6.32, -6.12]
otlp_http_to_blackhole ingress throughput -7.83 [-7.95, -7.70]

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI links
file_to_blackhole egress throughput -13.34 [-19.73, -6.95]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI links
syslog_regex_logs2metric_ddmetrics ingress throughput +4.86 [+4.70, +5.03]
syslog_humio_logs ingress throughput +3.78 [+3.55, +4.02]
syslog_log2metric_tag_cardinality_limit_blackhole ingress throughput +2.32 [+2.23, +2.40]
datadog_agent_remap_blackhole ingress throughput +2.29 [+2.15, +2.43]
http_elasticsearch ingress throughput +2.21 [+2.01, +2.42]
syslog_log2metric_humio_metrics ingress throughput +2.16 [+2.01, +2.31]
datadog_agent_remap_datadog_logs_acks ingress throughput +1.36 [+1.17, +1.54]
http_text_to_http_json ingress throughput +1.19 [+1.06, +1.32]
splunk_hec_to_splunk_hec_logs_acks ingress throughput +1.07 [+0.94, +1.20]
fluent_elasticsearch ingress throughput +0.44 [-0.05, +0.93]
syslog_splunk_hec_logs ingress throughput +0.35 [+0.26, +0.44]
http_to_s3 ingress throughput +0.25 [-0.02, +0.53]
http_to_http_acks ingress throughput +0.14 [-1.08, +1.37]
splunk_hec_route_s3 ingress throughput +0.09 [-0.21, +0.40]
http_to_http_json ingress throughput +0.07 [+0.01, +0.12]
http_to_http_noack ingress throughput +0.05 [+0.00, +0.10]
splunk_hec_to_splunk_hec_logs_noack ingress throughput +0.02 [-0.07, +0.12]
splunk_hec_indexer_ack_blackhole ingress throughput -0.02 [-0.10, +0.06]
syslog_log2metric_splunk_hec_metrics ingress throughput -0.08 [-0.18, +0.02]
syslog_loki ingress throughput -0.74 [-0.81, -0.66]
datadog_agent_remap_datadog_logs ingress throughput -0.85 [-1.12, -0.59]
otlp_grpc_to_blackhole ingress throughput -1.87 [-1.98, -1.76]
datadog_agent_remap_blackhole_acks ingress throughput -4.03 [-4.18, -3.88]
socket_to_socket_blackhole ingress throughput -6.22 [-6.32, -6.12]
otlp_http_to_blackhole ingress throughput -7.83 [-7.95, -7.70]
file_to_blackhole egress throughput -13.34 [-19.73, -6.95]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

github-actions[bot] avatar Oct 03 '24 22:10 github-actions[bot]

Regression Detector Results

Run ID: 95205601-07cc-40f0-a00d-be1365442aed Metrics dashboard

Baseline: 4588cec35cfae69aa9f606f1a32fdaa2c1283583 Comparison: 88d6fe7faca520bd28eba308bf08846eb1823975

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI links
file_to_blackhole egress throughput +0.46 [-6.54, +7.46]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI links
syslog_splunk_hec_logs ingress throughput +2.89 [+2.78, +3.01]
http_elasticsearch ingress throughput +2.29 [+2.10, +2.48]
fluent_elasticsearch ingress throughput +1.88 [+1.39, +2.38]
datadog_agent_remap_blackhole_acks ingress throughput +1.71 [+1.59, +1.82]
otlp_grpc_to_blackhole ingress throughput +1.70 [+1.58, +1.83]
syslog_log2metric_splunk_hec_metrics ingress throughput +1.60 [+1.46, +1.74]
otlp_http_to_blackhole ingress throughput +1.59 [+1.44, +1.75]
datadog_agent_remap_datadog_logs ingress throughput +1.38 [+1.16, +1.61]
datadog_agent_remap_blackhole ingress throughput +1.36 [+1.20, +1.51]
syslog_humio_logs ingress throughput +0.58 [+0.44, +0.73]
datadog_agent_remap_datadog_logs_acks ingress throughput +0.54 [+0.37, +0.71]
file_to_blackhole egress throughput +0.46 [-6.54, +7.46]
splunk_hec_route_s3 ingress throughput +0.46 [+0.16, +0.75]
http_to_s3 ingress throughput +0.45 [+0.17, +0.73]
socket_to_socket_blackhole ingress throughput +0.29 [+0.21, +0.38]
http_to_http_noack ingress throughput +0.12 [+0.05, +0.19]
http_to_http_json ingress throughput +0.07 [+0.02, +0.13]
splunk_hec_to_splunk_hec_logs_acks ingress throughput +0.07 [-0.04, +0.18]
splunk_hec_indexer_ack_blackhole ingress throughput +0.05 [-0.03, +0.13]
splunk_hec_to_splunk_hec_logs_noack ingress throughput +0.01 [-0.08, +0.10]
http_to_http_acks ingress throughput -0.18 [-1.41, +1.05]
syslog_loki ingress throughput -0.41 [-0.53, -0.28]
syslog_log2metric_tag_cardinality_limit_blackhole ingress throughput -0.63 [-0.74, -0.53]
syslog_regex_logs2metric_ddmetrics ingress throughput -0.74 [-0.88, -0.59]
syslog_log2metric_humio_metrics ingress throughput -1.77 [-1.92, -1.63]
http_text_to_http_json ingress throughput -2.77 [-2.90, -2.63]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

github-actions[bot] avatar Oct 04 '24 14:10 github-actions[bot]