semver4j Better NPM versions support

Better NPM versions support

Open algobardo opened this issue 8 years ago • 4 comments

Quick and dirty fixes for #7

Can you have a look ?

Feb 22 '17 13:02 algobardo

It looks like you have some test failures :( I'll let you see if they can be fixed.

Feb 22 '17 15:02 vdurmont

removed these tests

  Requirement.buildNPM("1.2.3-2.3.4"),
  Requirement.buildNPM("1.2.3 -2.3.4"),
  Requirement.buildNPM("1.2.3- 2.3.4"),

Feb 23 '17 10:02 algobardo

Well... Removing the tests definitely fixes the test failures but it looks like those tests were legit. Maybe we can try to fix the code instead?

Feb 24 '17 16:02 vdurmont

Well...they weren't (see https://github.com/npm/node-semver).

hyphen     ::= partial ' - ' partial

Feb 24 '17 18:02 algobardo