github-awards icon indicating copy to clipboard operation
github-awards copied to clipboard

Published 20 hours ago • verified publisher icon vdaubry

Unable to find certain cities. Stripping away accented chars?

Open fatso83 opened this issue 9 years ago • 3 comments

Take this guy. He has about 240 followers, but I am unable to find him in the javascript search, even though he has repos with 3000 stars.

Closest city match to "Kraków" was "Krakw". I am wondering if you are simply stripping accented characters? Then you should do a smarter normalization, since it does not seem to work propertly.

fatso83 avatar May 30 '16 09:05 fatso83

@fatso83 what do you think about https://github.com/vdaubry/github-awards/issues/203 ?

oprogramador avatar Jan 15 '20 12:01 oprogramador

Not sure how this bug is related to your feature request. Would be nice of course

fatso83 avatar Jan 15 '20 15:01 fatso83

This bug should be fixed but a workaround would be to have multiple cities with the same location: Kraków, Krakow, Cracow so searching for developers within 0 km from this city would find all.

So possibly Krakw could be another name though it's not the best idea because sometimes a city could be written entirely with non-English characters.

oprogramador avatar Jan 15 '20 16:01 oprogramador