typescript-retry-decorator icon indicating copy to clipboard operation
typescript-retry-decorator copied to clipboard

Published 20 hours ago • verified publisher icon vcfvct

Implement throw error with original error and reraise error

Open indahreforsiana opened this issue 3 years ago • 6 comments

  • implement throw error with the original error
  • add the option reraise error to rethrow the original error when it's reached max attempts

indahreforsiana avatar Aug 25 '22 14:08 indahreforsiana

@vcfvct It will resolve #17. but it seems conflicting with https://github.com/vcfvct/typescript-retry-decorator/commit/bfc517bc10defd862480f091f6253a05d7af6906

ibrohimislam avatar Aug 29 '22 06:08 ibrohimislam

@vcfvct any comment, about this pull request?

ibrohimislam avatar Sep 12 '22 11:09 ibrohimislam

@ibrohimislam this PR has conflict from the beginning ~

vcfvct avatar Sep 25 '22 13:09 vcfvct

yes, the conflict is because #18. and it's about the same issue.

ibrohimislam avatar Sep 25 '22 13:09 ibrohimislam

what do you think about the implementation? the conflict is easy to resolve.

ibrohimislam avatar Sep 25 '22 13:09 ibrohimislam

what do you think about the implementation? the conflict is easy to resolve.

oh, i was not looking much detail as there's conflict.

Just took a look and left some comments. @ibrohimislam are you the implementer?

vcfvct avatar Sep 25 '22 13:09 vcfvct

@indahreforsiana @ibrohimislam Since this has been pending here for month and the comments are not addressed. I have to implement that myself at #23 . Closing this for now. Please let me know if you have any concerns.

Thanks for your contribution.

vcfvct avatar Jan 17 '23 01:01 vcfvct