typedb icon indicating copy to clipboard operation
typedb copied to clipboard

Implement function execution for single-stage non-recursive stream functions

Open krishnangovindraj opened this issue 1 year ago • 1 comments

(Based off #7211 )

Release notes: product changes

Implement function execution for singles-stage non-recursive stream functions only. Non-stream functions will throw unimplemented. Recursive functions will either overflow your stack or blow up your heap. Do not write them! These will be implement in a subsequent release.

Sample query for usage:

           with
            fun get_ages($p_arg: person) -> { age }:
            match
                $p_arg has age $age_return;
            return {$age_return};

            match
                $p isa person;
                $z in get_ages($p);

Motivation

Implement some form of function execution end-to-end

Implementation

Mostly compiler package implementations for StepBuilder & lowering. Also wires up the ExecutableFunctionRegistry.

krishnangovindraj avatar Oct 16 '24 16:10 krishnangovindraj

PR Review Checklist

Do not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed.


Trivial Change

  • [ ] This change is trivial and does not require a code or architecture review.

Code

  • [ ] Packages, classes, and methods have a single domain of responsibility.
  • [ ] Packages, classes, and methods are grouped into cohesive and consistent domain model.
  • [ ] The code is canonical and the minimum required to achieve the goal.
  • [ ] Modules, libraries, and APIs are easy to use, robust (foolproof and not errorprone), and tested.
  • [ ] Logic and naming has clear narrative that communicates the accurate intent and responsibility of each module (e.g. method, class, etc.).
  • [ ] The code is algorithmically efficient and scalable for the whole application.

Architecture

  • [ ] Any required refactoring is completed, and the architecture does not introduce technical debt incidentally.
  • [ ] Any required build and release automations are updated and/or implemented.
  • [ ] Any new components follows a consistent style with respect to the pre-existing codebase.
  • [ ] The architecture intuitively reflects the application domain, and is easy to understand.
  • [ ] The architecture has a well-defined hierarchy of encapsulated components.
  • [ ] The architecture is extensible and scalable.

typedb-bot avatar Oct 16 '24 16:10 typedb-bot