bazel-distribution icon indicating copy to clipboard operation
bazel-distribution copied to clipboard

Update GitHub urls to reflect renaming the GitHub organisation

Open krishnangovindraj opened this issue 1 year ago • 4 comments

Usage and product changes

Updates usages of GitHub urls to reflect the vaticle organisation being renamed to TypeDB

Implementation

Updates github.com/vaticle/* repository urls to github.com/typedb/* in

  • dependency on rules kotlin The links in the readme remain untouched

krishnangovindraj avatar Jul 26 '24 16:07 krishnangovindraj

PR Review Checklist

Do not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed.


Trivial Change

  • [ ] This change is trivial and does not require a code or architecture review.

Code

  • [ ] Packages, classes, and methods have a single domain of responsibility.
  • [ ] Packages, classes, and methods are grouped into cohesive and consistent domain model.
  • [ ] The code is canonical and the minimum required to achieve the goal.
  • [ ] Modules, libraries, and APIs are easy to use, robust (foolproof and not errorprone), and tested.
  • [ ] Logic and naming has clear narrative that communicates the accurate intent and responsibility of each module (e.g. method, class, etc.).
  • [ ] The code is algorithmically efficient and scalable for the whole application.

Architecture

  • [ ] Any required refactoring is completed, and the architecture does not introduce technical debt incidentally.
  • [ ] Any required build and release automations are updated and/or implemented.
  • [ ] Any new components follows a consistent style with respect to the pre-existing codebase.
  • [ ] The architecture intuitively reflects the application domain, and is easy to understand.
  • [ ] The architecture has a well-defined hierarchy of encapsulated components.
  • [ ] The architecture is extensible and scalable.

typedb-bot avatar Jul 26 '24 16:07 typedb-bot

So this PR is blocked waiting on @krishnangovindraj to click the "trivial change" checkbox above?

I hope I don't seem obnoxious, I'm trying to understand the workflow.

Might be a question for @vmax

chickenandpork avatar Jan 30 '25 22:01 chickenandpork

@chickenandpork Do you somehow need this PR to get merged? It doesn't change anything in reality, as the vaticle org alias still works, and the zip file is downloadable through the old link. If you have any other issue with the Bazel distro, this PR will not solve it.

farost avatar Jan 31 '25 09:01 farost

@chickenandpork Do you somehow need this PR to get merged?

I was asking a question as an attempt to learn the impact on PRs to your project, whether it blocks review of very small diffs.

I appreciate your response; you've shared a lot.

chickenandpork avatar Jan 31 '25 23:01 chickenandpork