websocket-kit icon indicating copy to clipboard operation
websocket-kit copied to clipboard

refactor: use static ChannelOptions instead of raw definitions

Open Austinpayne opened this issue 8 months ago • 4 comments

Minor refactor to make better use of the Swift types exposed to set channel options.

Austinpayne avatar Mar 18 '25 02:03 Austinpayne

@gwynne any idea about CI failures?

MahdiBM avatar Mar 18 '25 12:03 MahdiBM

Yeah the tests use an old BoringSSL thing that no longer compiles - we need to fix it but latest macOS also broke some of the URL parsing. This is addressed in #155 I think, we need to check that in

0xTim avatar Mar 21 '25 12:03 0xTim

@Austinpayne can you bump the version of NIO that includes these changes in the manifest? I had a build failure when running locally because of outdated dependencies, then we can release (I'll bypass CI)

0xTim avatar Apr 10 '25 17:04 0xTim

Sorry for the delay! Out of curiosity which version did you have problems with? AFAICT these have been available maybe since swift-nio 2.32.0 and 2.17.0. Currently websocket-kit requires 2.53.0.

Austinpayne avatar Jun 03 '25 17:06 Austinpayne