jwt-kit icon indicating copy to clipboard operation
jwt-kit copied to clipboard

Lower minimum iOS version

Open Joannis opened this issue 1 year ago • 4 comments

We'd love to use JWTKit for some of our iOS code, but we need to support iOS 15. Is it possible and feasible to lower the iOS requirement? A quick check doesn't seem to indicate any iOS 16+ dependencies.

Joannis avatar Jul 26 '24 13:07 Joannis

This is a bug, not a feature request. When the Swift 6 compatibility PR was merged, the OS versions in the 5.10 manifest were bumped, although they shouldn't have been IIUC.

gwynne avatar Jul 26 '24 15:07 gwynne

We upped the minimum versions for JWTKit v5 so it's been like that for a while. I'm not against lowering it to iOS 15 but we probably need to have a discussion around our support rules and define them somewhere for new versions (e.g. should Vapor 5 support iOS 15 or should be go straight to 18 even if we're not using anything that requires it etc)

0xTim avatar Jul 26 '24 16:07 0xTim

I think iOS/macOS SDK considerations should use a completely different set of support rules compared to the likes of Swift toolchain versions. Bumping libraries to iOS 18+ unnecessarily simply prohibits use in almost every app.

Joannis avatar Jul 26 '24 18:07 Joannis

Yeah it's a symptom of the platforms mess in SwiftPM. Very happy to accept a PR for iOS 15 though (and other related platforms) - I can't see that holding us up much in the future. Otherwise I'll get to it next week

0xTim avatar Jul 28 '24 18:07 0xTim