Imperial icon indicating copy to clipboard operation
Imperial copied to clipboard

Add More OAuth Providers

Open calebkleveter opened this issue 8 years ago β€’ 14 comments

GitHub makes a good start for supported OAuth providers, but we need more. Below are a few I would like to add:

  • [ ] Twitter
  • [x] Google
  • [x] Facebook
  • [ ] Instagram

or any others that we think would be good.

Note to maintainer: Look into Auth0

calebkleveter avatar Nov 13 '17 18:11 calebkleveter

Wouldn't Auth0 be a great option since they can then be a proxy for other providers like the ones above?

kdawgwilk avatar Jan 19 '18 00:01 kdawgwilk

I have never really looked into Auth0 all that much. I'll add a reminder to the issue πŸ‘.

calebkleveter avatar Jan 19 '18 11:01 calebkleveter

Is there a chance we can get Uber support?

maldahleh avatar Jun 08 '18 18:06 maldahleh

@maldahleh That sounds like a great idea, but I am relying on other people's contributions for certain services, meaning I have no timeframe as to when that would get added. If you want to contribute, that would be great, if not, no sweat πŸ™‚.

calebkleveter avatar Jun 08 '18 20:06 calebkleveter

@calebkleveter I'm implementing Facebook and Twitter logins for my app. I'll get some prototype code working with Github first, to get an idea of how this all fits together, and then I'll take a stab at Facebook and then Twitter.

Question: What is the architectural reason for including each provider in the main library? Other similar libraries like OmniAuth have a core library and then you can use the specific provider needed.

natebird avatar Jan 21 '19 12:01 natebird

@natebird see #19 for a Facebook integration - I think it works. As for the second question, see #24 !

0xTim avatar Jan 21 '19 13:01 0xTim

@0xTim - great! I'm trying out the Facebook integration now. I'll let you know if it actually works. :-P

natebird avatar Jan 21 '19 13:01 natebird

@natebird If it works (or you get it working) and you happen to have time to throw together a getting started guide so we can merge #19, that would be great! If not, it won't hurt to sit around a bit longer πŸ˜„

calebkleveter avatar Jan 21 '19 15:01 calebkleveter

I pushed up a starter guide for Facebook integration to #19. I have a working implementation in development using SSL.

natebird avatar Jan 22 '19 16:01 natebird

Keycloak support is planned?

gaetandezeiraud avatar Apr 12 '19 06:04 gaetandezeiraud

@Brouilles I don’t think it is but please send a PR if you do it :)

rafiki270 avatar Apr 12 '19 07:04 rafiki270