Aliaksandr Valialkin

Results 630 comments of Aliaksandr Valialkin

VictoriaMetrics uses https://github.com/klauspost/compress library for data compression / decompression when GCO is disabled. The commit 2fc7e9f47e4e30dbb55860a4eb622de35887bea1 uses `v1.17.0` release of this library (see `go.mod` file contents in this commit), while...

VictoriaMetrics shouldn't expand `WITH` templates during query prettifying after the commit 2e30842582865910c9eb34ac0b7618dbedb59ae7 . This commit will be included in the next release.

[vmui](https://docs.victoriametrics.com/#vmui) doesn't expand [`WITH` templates](https://play.victoriametrics.com/select/accounting/1/6a716b0f-38bc-4856-90ce-448fd713e3fe/prometheus/graph/?#/expand-with-exprs) when clicking the `prettify query` button starting from the release [v1.99.0](https://docs.victoriametrics.com/changelog/). Closing the feature request as done.

Please see also https://github.com/VictoriaMetrics/VictoriaMetrics/issues/816#issuecomment-1665672676

Re-opening the issue, since it looks like it isn't resolved yet. @renchili , @mmkkoo , could you try [vmagent from the latest release (v1.97.1)](https://github.com/VictoriaMetrics/VictoriaMetrics/releases/latest)? It contains some optimizations, which may...

@blesswinsamuel , could you try building vmagent from the commit babecd83632446b6f24b57266def3782cf39c07d and verifying whether it helps removing memory usage spikes when the target changes the set of exposed metrics?

@blesswinsamuel , thanks for the confirmation that the memory usage spikes are gone in vmagent now! The bugfix has been included in [vmagent v1.87.0](https://github.com/VictoriaMetrics/VictoriaMetrics/releases). Closing the issue as fixed.

@lzfhust , see also the follow-up commit 68463c9e87303a587a9af1d054aa32c9efeae31a , which should further reduce memory usage spikes when big number of scrape targets disappear at once. It limits the number of...

Both improvements - https://github.com/VictoriaMetrics/VictoriaMetrics/commit/d79f1b106c2fd60d8760419fc4acb57d39cfd1c2 and https://github.com/VictoriaMetrics/VictoriaMetrics/commit/68463c9e87303a587a9af1d054aa32c9efeae31a - have been included in [vmagent v1.86.2](https://github.com/VictoriaMetrics/VictoriaMetrics/releases). @lzfhust , could you confirm that `vmagent v1.86.2` doesn't have memory spikes when big number of scrape...

@lzfhust , could you try building vmagent from the commit babecd83632446b6f24b57266def3782cf39c07d and verifying whether this fixes memory usage spikes when big number of scrape targets are deleted in kubernetes?