prisma-kysely
prisma-kysely copied to clipboard
List enum values should be typed as strings
This PR introduces a fix where enum list values are typed as MyEnum[] but Prisma's migrations actually store them as a string format.
Since kysely is just a query builder, we couldn't expect it to parse this string format into an array, so I think it makes the most sense to have it typed like this.
If you would like to merge this, please could I ask you throughly check the PR, it's very possible I've missed something as I only spent a few minutes looking around the codebase for supporting this feature.
Thanks for prisma-kysely, it's a wonderful tool!
fixes #107
Hi @valtyr are you still working on prisma-kysely? Appreciate your time is precious especially in open source, so thank you for your hard work. Would you be looking for maintainers to help out manage prisma-kysely? Would love to see this PR merged and released if you think it's a good addition. Cheers
Hey @alii, I'm sorry for the late reply. Nice work on this PR! Sadly, prisma-kysely has been on the backburner recently cause of work stuff... but thankfully there's not a lot of maintenance that needs to happen here in general. Seems to me like the code all makes sense. Would be be so kind as to adding a changeset with a minor version bump, that explains that this version includes breaking changes to the way we handle arrays of enums in Postgres. That way we can get this merged and deployed ASAP.
I'm open to having a co-maintainer on the project. Is that something that you would be interested in? If so we could have a chat about things on Discord, just let me know.
Hey @alii, I'm sorry for the late reply. Nice work on this PR! Sadly, prisma-kysely has been on the backburner recently cause of work stuff... but thankfully there's not a lot of maintenance that needs to happen here in general. Seems to me like the code all makes sense. Would be be so kind as to adding a changeset with a minor version bump, that explains that this version includes breaking changes to the way we handle arrays of enums in Postgres. That way we can get this merged and deployed ASAP.
I'm open to having a co-maintainer on the project. Is that something that you would be interested in? If so we could have a chat about things on Discord, just let me know.
No worries, must reiterate how amazing the work is you've done so far, so really a big thanks.
Regards to co-maintaining, I would be happy to do that! What's your Discord?
Will get to making these adjustments asap, thanks again.
Hey @alii, I'm sorry for the late reply. Nice work on this PR! Sadly, prisma-kysely has been on the backburner recently cause of work stuff... but thankfully there's not a lot of maintenance that needs to happen here in general. Seems to me like the code all makes sense. Would be be so kind as to adding a changeset with a minor version bump, that explains that this version includes breaking changes to the way we handle arrays of enums in Postgres. That way we can get this merged and deployed ASAP. I'm open to having a co-maintainer on the project. Is that something that you would be interested in? If so we could have a chat about things on Discord, just let me know.
No worries, must reiterate how amazing the work is you've done so far, so really a big thanks.
Regards to co-maintaining, I would be happy to do that! What's your Discord?
Will get to making these adjustments asap, thanks again.
Haha thanks, I'm just happy that my code can be useful to others.
It would be awesome if you'd be willing to consider joining as a co-maintainer. Let's find time to chat. My username is valtyrorn on Discord, you can message me there.