valadoc-org icon indicating copy to clipboard operation
valadoc-org copied to clipboard

Is there a need for Font-awesome?

Open cjfloss opened this issue 6 years ago • 1 comments

Looking through the code I could only find two references to font-awesome icons and searching on github for fa I get the same results.

On index.php#L80 for the reddit icon and index.php#L81 for the info icon.

So is there really a need for inporting all the font awesome for just two icons or am I missing something?

Removing it and running locally on firefox in the index page I get this:

With font-awesome

18 requests
394.60 KB / 361.66 KB transferred
Finish: 834 ms
DOMContentLoaded: 331 ms
load: 845 ms

Without font-awesome

16 requests
288.82 KB / 278.43 KB transferred
Finish: 429 ms
DOMContentLoaded: 296 ms
load: 451 ms

cjfloss avatar Jun 07 '19 03:06 cjfloss

Yeah we don't need to load all of font awesome. It's overkill

danirabbit avatar Sep 19 '19 16:09 danirabbit