platform icon indicating copy to clipboard operation
platform copied to clipboard

NPM Bundle needs different versions in Vaadin 24.4.4

Open subITCSS opened this issue 1 year ago • 1 comments
trafficstars

Describe the bug

We discoverd another problem with the new version: To create our sbom we check the npm references and getting this error:

npm error code ELSPROBLEMS
npm error invalid: @open-wc/[email protected] /node_modules/@open-wc/dedupe-mixin

The Issue we discovered is that the vaadin-bundles requires the fixed version of 1.3.1 for it image

while all components require the ^1.3.0 and as there is an 1.4.0 the system updates the dependency to 1.4.0 which clashes with the upper fixed definition. image

So based on this the Versions should be both fix or flexible using the ^.

Expected-behavior

Both versions are defined identical

Reproduction

Check the npm dependencies.

System Info

Vaadin 24.4.4

subITCSS avatar Jun 27 '24 11:06 subITCSS

Thanks for the ticket.. i have applied the fix to vaadin/bundles.

ZheSun88 avatar Jun 28 '24 07:06 ZheSun88

When will this be solved/merged?- This should be available in the 24.4.5 cause it is causing our pipeline to stop

subITCSS avatar Jul 08 '24 12:07 subITCSS

vaadin 24.4.5 has been released a few while ago. Can you test again?

ZheSun88 avatar Jul 08 '24 13:07 ZheSun88

So based on what i see - the version did not change/solve this. And based on the situatiuon that your PullRequest is still open - would clearify that.

subITCSS avatar Jul 08 '24 14:07 subITCSS

ah, i see.. sorry for the inconvenience, i will ask the team to merge those PRs and make another release ASAP

ZheSun88 avatar Jul 09 '24 05:07 ZheSun88

Vaadin 24.4.6 has been released with the version fix in bundles

ZheSun88 avatar Jul 09 '24 10:07 ZheSun88