platform icon indicating copy to clipboard operation
platform copied to clipboard

Split react-components into core and pro parts

Open mshabarov opened this issue 1 year ago • 3 comments

Describe your motivation

Vaadin Core / open source users should be able to use core/free React components without Vaadin license.

Describe the solution you'd like

Acceptance Criteria:

  • [x] React components are split into @vaadin/react-components (free) and @vaadin/react-components-pro (commercial) npm packages, this change is re-applied
  • [x] Platform versions has react-components in core and react-components-pro in vaadin
  • [x] Flow adds @vaadin/react-components-pro package into package.json in vaadin dependency is used in a project. @vaadin/react-components are added for both vaadin-core and vaadin.

Note: this is planned between 24.4 beta and GA, so that these changes don't block beta release and beta testing.

Describe alternatives you've considered

No response

Additional context

Vaadin 24.4.

mshabarov avatar Apr 02 '24 13:04 mshabarov

Created the React components split PR: https://github.com/vaadin/react-components/pull/242

web-padawan avatar Apr 03 '24 09:04 web-padawan

Flow will pick/discard react components by the mode flag ("mode": "react") in the versions files and both vaadin-core-versions.json and vaadin-versions.json are always checked if available so for Flow there is nothing extra for step 3 to add.

Extended test to check this case explicitly: https://github.com/vaadin/flow/pull/19103

caalador avatar Apr 04 '24 10:04 caalador

i have pushed a branch in platform with the necessary changes. let us wait after beta https://github.com/vaadin/platform/tree/react-component-pro

ZheSun88 avatar Apr 05 '24 08:04 ZheSun88

Done. Tested with having vaadin and vaadin-core. Vaadin adds react-components-pro in the first case and does not in the second case.

mshabarov avatar May 08 '24 07:05 mshabarov