platform icon indicating copy to clipboard operation
platform copied to clipboard

SideNav: link target API

Open rolfsmeds opened this issue 1 year ago • 0 comments
trafficstars

Description

API for configuring a link in SideNav to open in a new browser window/tab.

Acceptance criteria

  • [ ] API for setting/getting the target attribute for the link in a SideNavItem (Flow: setTarget(String), getTarget(); target property for WC & React);
  • [ ] Convenience API in Flow SideNavItem for opening the link in a new, unnamed browser tab: setOpenInNewBrowserTab(boolean) and corresponding getter (equivalent to setTarget("_blank")

Notes

  • Setting rel="noopener" is unnecessary as that is the default for target="_blank" in modern browsers.
  • Setting rel="noreferer" to be covered by a separate issue.

Original feature request issue: https://github.com/vaadin/flow-components/issues/5091

General criteria

  • [ ] UX/DX tests in Alpha
  • [ ] Documentation: New Opening in new browser tab section in SideNav docs page (add link here when done)

  • [ ] How to test?

  • [ ] Limitations:

Security

  • [x] Security implications have been taken into account (elaborate or link to product security requirement specification if there are implications)

rolfsmeds avatar Dec 20 '23 20:12 rolfsmeds