flow-components icon indicating copy to clipboard operation
flow-components copied to clipboard

chore: class com.vaadin.flow.component.sidenav.SideNavItemContainer has been made public.

Open ovsyannykov opened this issue 8 months ago • 1 comments

Description

The public modifier for the com.vaadin.flow.component.sidenav.SideNavItemContainer class makes it possible to use its methods, in particular "public void addItem(SideNavItem... items)", for both SideNav and SideNavItem, which simplifies the code for creating a hierarchical menu.

Type of change

  • [ ] Bugfix
  • [x] Feature

Issue

#5089 Please make The SideNavItemContainer class public

Checklist

  • [x] I have read the contribution guide: https://vaadin.com/docs/latest/contributing/overview
  • [x] I have added a description following the guideline.
  • [x] The issue is created in the corresponding repository and I have referenced it.
  • [x] I have added tests to ensure my change is effective and works as intended - no need.
  • [x] New and existing tests are passing locally with my change.
  • [x] I have performed self-review and corrected misspellings.
  • [ ] I have not completed some of the steps above and my pull request can be closed immediately.

Additional for Feature type of change

  • [ ] Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

ovsyannykov avatar Mar 21 '25 09:03 ovsyannykov

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Mar 21 '25 09:03 CLAassistant

Closing in favour of https://github.com/vaadin/flow-components/pull/7266, which converts the class to an interface.

ugur-vaadin avatar Apr 03 '25 07:04 ugur-vaadin