web-tooling-benchmark icon indicating copy to clipboard operation
web-tooling-benchmark copied to clipboard

Add benchmark for ESLint

Open matthewnbrown opened this issue 6 years ago • 4 comments

I added the jshint.js file which ESLint uses as its performance benchmark. The file is rather large though, so it makes this benchmark the slowest of them all. I can remove it if desired.

matthewnbrown avatar Mar 05 '19 20:03 matthewnbrown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

googlebot avatar Mar 05 '19 20:03 googlebot

I signed it

matthewnbrown avatar Mar 05 '19 20:03 matthewnbrown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

googlebot avatar Mar 05 '19 20:03 googlebot

So there's good news and bad news.

:thumbsup: The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

:confused: The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

googlebot avatar Mar 06 '19 09:03 googlebot