godot-kotlin-jvm icon indicating copy to clipboard operation
godot-kotlin-jvm copied to clipboard

Published 20 hours ago • verified publisher icon utopia-rise

Fix ide plugin issues

Open chippmann opened this issue 3 years ago • 4 comments

Resolves #346, resolves #345 and resolves #347.

  • Fixes compatibility issues reported by Jetbrains regarding our plugin for older IDE versions
  • Fixes false positives for registration of overridden abstract functions (#345)
  • Fixes plugin crash on IDE version 2022.2 with kotlin plugin 222.3345.118 or newer (#346)
  • Fixes false positives for core type copy mutation with chained calls (#347)

chippmann avatar Aug 11 '22 15:08 chippmann

Maybe you can directly target master, as develop branch is going to die with 3.5 release.

piiertho avatar Aug 13 '22 11:08 piiertho

Maybe you can directly target master, as develop branch is going to die with 3.5 release.

But isn't this going to be merge beforehand and would then be merged directly together with the 3.5 changes?

chippmann avatar Aug 13 '22 12:08 chippmann

Maybe you can directly target master, as develop branch is going to die with 3.5 release.

But isn't this going to be merge beforehand and would then be merged directly together with the 3.5 changes?

This would do less to review when merging develop in master if we merge this directly to master

piiertho avatar Aug 13 '22 13:08 piiertho

Maybe you can directly target master, as develop branch is going to die with 3.5 release.

But isn't this going to be merge beforehand and would then be merged directly together with the 3.5 changes?

This would do less to review when merging develop in master if we merge this directly to master

true will do that

chippmann avatar Aug 13 '22 13:08 chippmann

I'm trying to get started with Godot and #346 is bugging me. Looks like this can be merged?

travisfw avatar Aug 17 '22 17:08 travisfw

I'm trying to get started with Godot and #346 is bugging me. Looks like this can be merged?

@travisfw If it's urgent to you, you can build the plugin yourself and install it locally from disk: https://www.jetbrains.com/help/idea/managing-plugins.html#install_plugin_from_disk

To build the plugin:

  • check out our project: git clone [email protected]:utopia-rise/godot-kotlin-jvm.git
  • navigate to the kotlin sources cd godot-kotlin-jvm/kt
  • build the ide plugin: ./gradlew :godot-intellij-plugin:assemble
  • the resulting plugin (what you need to select when installing the plugin locally) will be a zip file in kt/plugins/godot-intellij-plugin/build/distributions

Our next release should not be far away though. After #344 is merged (i still need to do the linux testing), we can probably do a release.

chippmann avatar Aug 17 '22 19:08 chippmann