godot-kotlin-jvm icon indicating copy to clipboard operation
godot-kotlin-jvm copied to clipboard

Published 20 hours ago • verified publisher icon utopia-rise

bugfix: embedd JRE in export app

Open piiertho opened this issue 3 years ago • 6 comments

This makes difference between JRE for arm and amd systems. This fixes OSX exports by making use of Plugins app folder. Only applicable to Godot 3.5+ versions.

This resolves #266

piiertho avatar Jul 22 '22 09:07 piiertho

We need to check all exports (all os + hotspot / graal native image) before merging this

piiertho avatar Jul 25 '22 12:07 piiertho

Tested on windows for both hotspot and graal native image.

piiertho avatar Aug 05 '22 15:08 piiertho

LGTM But reminder that at some point we should rework everything related to systems and arch as it's becoming quite messy.

CedNaru avatar Aug 07 '22 09:08 CedNaru

LGTM But reminder that at some point we should rework everything related to systems and arch as it's becoming quite messy.

Maybe you can write an issue so that we don't forget ?

piiertho avatar Aug 07 '22 13:08 piiertho

Tested on Android.

piiertho avatar Aug 08 '22 16:08 piiertho

Tested all exports (arm64, x86_64 and universal) for MacOS with hotspot.

piiertho avatar Aug 10 '22 09:08 piiertho

Tested on linux;

  • Editor binary without jre: OK

  • Editor binary with jre: OK

  • Release_debug export: OK

  • Release export: Ok

Found another issue: #354. But this does not need to be addressed in this PR IMO

Only issues i found are small things in the docs

I agree this should be done in another PR.

piiertho avatar Aug 19 '22 07:08 piiertho