database icon indicating copy to clipboard operation
database copied to clipboard

Published 20 hours ago • verified publisher icon utopia-php

Added code linter

Open abhishek-sultaniya opened this issue 3 years ago • 2 comments

Fixes issue 4352

abhishek-sultaniya avatar Oct 13 '22 08:10 abhishek-sultaniya

PR looks good to me regarding the main changes. Please allow us some more time to go over all changes to ensure no logic was broken by the linter changes.

Does it need any change?

abhishek-sultaniya avatar Oct 28 '22 17:10 abhishek-sultaniya

@abhishek-sultaniya, did you just run the format and check everything in?

stnguyen90 avatar Oct 29 '22 00:10 stnguyen90

Thank you so much for the PR 🤩. We're adding the hacktoberfest-accepted label to ensure this PR counts towards your Hacktoberfest contributions count. With that said, please stay active on this PR to address any comments once you receive a review. Happy Hacktoberfest! 🎃

PineappleIOnic avatar Oct 31 '22 16:10 PineappleIOnic

@abhishek-sultaniya, did you just run the format and check everything in?

Yup,I tried that.

abhishek-sultaniya avatar Oct 31 '22 20:10 abhishek-sultaniya

@abhishek-sultaniya would you please revert your auto format changes so that you only have the workflow and composer changes (fixing the merge conflicts as well)? Since there are so many changes to the library, it would be best for someone on the core team to run the formatter and merge ASAP to reduce conflicts.

Please could you explain how can I revert the auto format changes.

abhishek-sultaniya avatar Nov 08 '22 13:11 abhishek-sultaniya

@abhishek-sultaniya, maybe this will help: https://stackoverflow.com/questions/4795600/reverting-part-of-a-commit-with-git

stnguyen90 avatar Nov 08 '22 15:11 stnguyen90

@abhishek-sultaniya Would you like to try to revert the formatting changes?

abnegate avatar Jan 10 '23 08:01 abnegate

Closing for now due to inactivity

abnegate avatar Jan 27 '23 09:01 abnegate