cli icon indicating copy to clipboard operation
cli copied to clipboard

Published 20 hours ago • verified publisher icon utopia-php

Add Code Linter To ‘utopia-php/cli

Open vasucp1207 opened this issue 3 years ago • 1 comments

PR related to this issue.

vasucp1207 avatar Oct 14 '22 12:10 vasucp1207

  • @stnguyen90, check now.
Screenshot 2022-10-27 at 12 14 44 AM

vasucp1207 avatar Oct 26 '22 18:10 vasucp1207

@vasucp1207 The tests are failing. Please run and fix all the linter issues and update the PR

christyjacob4 avatar Dec 20 '22 22:12 christyjacob4

@christyjacob4, I think the tests are failing due to the linter check. I also check the adding code linter PR's in other repos their tests are also failing.

vasucp1207 avatar Dec 21 '22 18:12 vasucp1207

@christyjacob4, it looks like travis is using phpcs and fails because the styling conflicts with pint.

The command "vendor/bin/phpcs -p" exited with 2.

stnguyen90 avatar Dec 22 '22 18:12 stnguyen90

THANK YOU! All changes merged 🥳

Please reach out to me on our Discord server if you would like to claim your Appwrite swags! As a way of saying thank you, we would also love to invite you to join the Appwrite organization on GitHub. Please share your GitHub username with us on Discord.  

You can accept the invite by visiting https://github.com/orgs/appwrite/invitation. By joining our team, you will officially be an Appwrite maintainer on GitHub.

You can change your membership visibility settings, so your new Appwrite team membership badge will show up on your personal GitHub profile.

Please feel free to look for more PRs you might be interested in helping with on our long list of Hacktoberfest friendly issues and help make Appwrite better :)

christyjacob4 avatar Jan 27 '23 20:01 christyjacob4