audit icon indicating copy to clipboard operation
audit copied to clipboard

Published 20 hours ago • verified publisher icon utopia-php

Added code analyzer

Open mohakgupt opened this issue 3 years ago • 5 comments

Fixes appwrite/appwrite#4389. I have used PHPStan as the analyzer. Also fixed the errors thrown by the analyzer.

Screenshot 2022-10-21 020220

mohakgupt avatar Oct 20 '22 20:10 mohakgupt

@Meldiron any update on this

mohakgupt avatar Oct 28 '22 04:10 mohakgupt

Thank you so much for the PR 🤩. We're adding the hacktoberfest-accepted label to ensure this PR counts towards your Hacktoberfest contributions count. With that said, please stay active on this PR to address any comments once you receive a review. Happy Hacktoberfest! 🎃

PineappleIOnic avatar Oct 31 '22 16:10 PineappleIOnic

I still got an error when I ran the check:

image

stnguyen90 avatar Nov 11 '22 00:11 stnguyen90

I still got an error when I ran the check:

image

It is running the test on max level. Running ./vendor/bin/phpstan analyse --level 8 src tests will give no errors. I have fixed the errors on level 8 as in the issue description it was said to use level 8. Thanks.

mohakgupt avatar Nov 11 '22 02:11 mohakgupt

I have done all the changes.

mohakgupt avatar Nov 16 '22 07:11 mohakgupt

THANK YOU! All changes merged 🥳

Please reach out to me on our Discord server if you would like to claim your Appwrite swags! As a way of saying thank you, we would also love to invite you to join the Appwrite organization on GitHub. Please share your GitHub username with us on Discord.  

You can accept the invite by visiting https://github.com/orgs/appwrite/invitation. By joining our team, you will officially be an Appwrite maintainer on GitHub.

You can change your membership visibility settings, so your new Appwrite team membership badge will show up on your personal GitHub profile.

Please feel free to look for more PRs you might be interested in helping with on our long list of Hacktoberfest friendly issues and help make Appwrite better :)

christyjacob4 avatar Jan 27 '23 14:01 christyjacob4