rascal icon indicating copy to clipboard operation
rascal copied to clipboard

rewrote squeeze in Rascal with reified classes

Open jurgenvinju opened this issue 1 year ago • 1 comments

  • this does not pass the type-checker because of an intricate issue with type parameters of the type[..] constructor.
  • it reuses the [a-z] character class notation instead of strings for the second parameter of squeeze
  • it reuses @davylandman's visit pure Rascal implementation of squeeze

jurgenvinju avatar Jul 17 '24 08:07 jurgenvinju

Codecov Report

Attention: Patch coverage is 17.85714% with 23 lines in your changes missing coverage. Please review.

Project coverage is 49%. Comparing base (1690da7) to head (2b24936). Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
...org/rascalmpl/values/parsetrees/SymbolFactory.java 17% 23 Missing :warning:
Additional details and impacted files
@@           Coverage Diff           @@
##              main   #2002   +/-   ##
=======================================
  Coverage       49%     49%           
- Complexity    6309    6322   +13     
=======================================
  Files          664     664           
  Lines        59633   59584   -49     
  Branches      8648    8640    -8     
=======================================
+ Hits         29486   29497   +11     
+ Misses       27938   27877   -61     
- Partials      2209    2210    +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

codecov[bot] avatar Jul 17 '24 08:07 codecov[bot]

This now also fixes the other issues identified in #2009 and some more because of better testing (especially now character escaping works the same for literals, ci-iterals and character classes). The \f case has to be fixed in vallang.

jurgenvinju avatar Nov 21 '24 10:11 jurgenvinju

@PaulKlint Davy has looked at it and the PR I merged into this was also reviewed already. Many more tests were added; I think the compiler will not have issue with those.

jurgenvinju avatar Nov 21 '24 10:11 jurgenvinju

@jurgenvinju

The \f case has to be fixed in vallang.

it has been, just not released a new version of vallang yet.

DavyLandman avatar Nov 21 '24 11:11 DavyLandman

Check!

jurgenvinju avatar Nov 21 '24 13:11 jurgenvinju